add test

Author: rickeylev

MODULE.bazel

@@ -103,6 +103,8 @@ use_repo(
     internal_dev_deps,
     "buildkite_config",
     "rules_python_runtime_env_tc_info",
+    "somepkg_with_build_files",
+    "whl_with_build_files",
 )
 
 # Add gazelle plugin so that we can run the gazelle example as an e2e integration

python/private/internal_dev_deps.bzl

@@ -14,6 +14,8 @@
 """Module extension for internal dev_dependency=True setup."""
 
 load("@bazel_ci_rules//:rbe_repo.bzl", "rbe_preconfig")
+load("//python/private/pypi:whl_library.bzl", "whl_library")
+load("//tests/support/whl_from_dir:whl_from_dir_repo.bzl", "whl_from_dir_repo")
 load(":runtime_env_repo.bzl", "runtime_env_repo")
 
 def _internal_dev_deps_impl(mctx):
@@ -28,6 +30,17 @@ def _internal_dev_deps_impl(mctx):
     )
     runtime_env_repo(name = "rules_python_runtime_env_tc_info")
 
+    whl_from_dir_repo(
+        name = "whl_with_build_files",
+        root = "//tests/whl_with_build_files/testdata:BUILD.bazel",
+        output = "somepkg-1.0-any-none-any.whl",
+    )
+    whl_library(
+        name = "somepkg_with_build_files",
+        whl_file = "@whl_with_build_files//:somepkg-1.0-any-none-any.whl",
+        requirement = "somepkg",
+    )
+
 internal_dev_deps = module_extension(
     implementation = _internal_dev_deps_impl,
     doc = "This extension creates internal rules_python dev dependencies.",

python/private/pypi/whl_library.bzl

@@ -249,6 +249,7 @@ def _whl_library_impl(rctx):
 
     whl_path = None
     if rctx.attr.whl_file:
+        rctx.watch(rctx.attr.whl_file)
         whl_path = rctx.path(rctx.attr.whl_file)
 
         # Simulate the behaviour where the whl is present in the current directory.

tests/support/whl_from_dir/BUILD.bazel

@@ -0,0 +1,54 @@
+"""Creates a whl file from a directory tree.
+
+Used to test wheels. Avoids checking in prebuilt files and their associated
+security risks.
+"""
+
+load("//python/private:repo_utils.bzl", "repo_utils")
+
+def _whl_from_dir_repo(rctx):
+    manifest = []
+
+    root = rctx.path(rctx.attr.root).dirname
+    # todo: recursively watch so it regens automatically
+    ##paths = list(root.readdir(watch = "yes"))
+    ##for _ in range(1000):
+    ##    if not paths:
+    ##        break
+    ##    path = paths.pop()
+    ##    if path.is_dir:
+    ##        paths.extend(path.readdir(watch = "yes"))
+    ##    else:
+    ##        zip_path = str(path).removeprefix(root + "/")
+    ##        actual_path = str(path)
+    ##        manifest.append("{}={}".format(zip_path, actual_path))
+
+    print("Watch: {}".format(root))
+    rctx.watch_tree(root)
+
+    ##rctx.file("files.txt", manifest)
+    output = rctx.path(rctx.attr.output)
+    output = repo_utils.execute_checked_stdout(
+        rctx,
+        # cd to root so zip recursively takes everything there.
+        working_directory = str(root),
+        op = "WhlFromDir",
+        arguments = [
+            "zip",
+            "-v",
+            "-0",
+            str(output),
+            "-r",
+            ".",
+        ],
+    )
+    print(output)
+    rctx.file("BUILD.bazel", 'exports_files(glob(["*"]))')
+
+whl_from_dir_repo = repository_rule(
+    implementation = _whl_from_dir_repo,
+    attrs = {
+        "root": attr.label(),
+        "output": attr.string(),
+    },
+)

tests/support/whl_from_dir/whl_from_dir_repo.bzl

@@ -0,0 +1,7 @@
+load("//python:py_test.bzl", "py_test")
+
+py_test(
+    name = "verify_files_test",
+    srcs = ["verify_files_test.py"],
+    deps = ["@somepkg_with_build_files//:pkg"],
+)