Skip to content

Commit 42930cc

Browse files
shs96crickeylev
andauthored
fix: Make sure wheelmaker uses the default shell env (#2477)
Clean macOS installs place `python` in `/usr/local/bin`, which is not searched by default when calling `actions.run()`. This caused builds to fail when they were executing python tools on an unmodified macOS host. --------- Co-authored-by: Richard Levasseur <[email protected]> Co-authored-by: Richard Levasseur <[email protected]>
1 parent 094a256 commit 42930cc

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ Unreleased changes template.
5656

5757
{#v0-0-0-fixed}
5858
### Fixed
59-
* Nothing fixed.
59+
* (py_wheel) Use the default shell environment when building wheels to allow
60+
toolchains that search PATH to be used for the wheel builder tool.
6061

6162
{#v0-0-0-added}
6263
### Added

python/private/py_wheel.bzl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -514,6 +514,9 @@ def _py_wheel_impl(ctx):
514514
outputs = [outfile, name_file],
515515
arguments = [args],
516516
executable = ctx.executable._wheelmaker,
517+
# The default shell env is used to better support toolchains that look
518+
# up python at runtime using PATH.
519+
use_default_shell_env = True,
517520
progress_message = "Building wheel {}".format(ctx.label),
518521
)
519522
return [

0 commit comments

Comments
 (0)