Skip to content

Commit 46b8d99

Browse files
Jonathon Belottihrfuller
andauthored
remove wording incorrectly suggesting python2 was supported by pip_install (#495)
Co-authored-by: Henry Fuller <[email protected]>
1 parent 4a0edcc commit 46b8d99

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,7 @@ used to invoke pip matches the interpreter used to run `py_binary` targets. By
108108
default, `pip_install` uses the system command `"python3"`. This can be overridden by passing the
109109
`python_interpreter` attribute or `python_interpreter_target` attribute to `pip_install`.
110110

111-
You can have multiple `pip_install`s in the same workspace, e.g. for Python 2
112-
and Python 3. This will create multiple central repos that have no relation to
111+
You can have multiple `pip_install`s in the same workspace. This will create multiple central repos that have no relation to
113112
one another, and may result in downloading the same wheels multiple times.
114113

115114
As with any repository rule, if you would like to ensure that `pip_install` is
@@ -153,13 +152,14 @@ install_deps()
153152

154153
### Importing `pip` dependencies with `pip_import` (legacy)
155154

156-
The deprecated `pip_import` can still be used if needed.
155+
The deprecated `pip_import` can still be used if needed. It is the only packaging rule that supports Python 2,
156+
which has been [sunsetted since January 1st, 2020](https://www.python.org/doc/sunset-python-2/).
157157

158158
```
159159
load("@rules_python//python/legacy_pip_import:pip.bzl", "pip_import", "pip_repositories")
160160
161161
# Create a central repo that knows about the dependencies needed for requirements.txt.
162-
pip_import( # or pip3_import
162+
pip_import(
163163
name = "my_deps",
164164
requirements = "//path/to:requirements.txt",
165165
)

0 commit comments

Comments
 (0)