Skip to content

Commit 472cc40

Browse files
committed
comment: use enum
1 parent 1c54116 commit 472cc40

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

python/config_settings/BUILD.bazel

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ load(
55
"AddSrcsToRunfilesFlag",
66
"BootstrapImplFlag",
77
"ExecToolsToolchainFlag",
8+
"FreeThreadedFlag",
89
"PrecompileFlag",
910
"PrecompileSourceRetentionFlag",
1011
)
@@ -94,19 +95,14 @@ string_flag(
9495

9596
string_flag(
9697
name = "py_freethreaded",
97-
build_setting_default = "no",
98-
values = [
99-
"yes",
100-
"no",
101-
],
98+
build_setting_default = FreeThreadedFlag.NO,
99+
values = sorted(FreeThreadedFlag.__members__.values()),
102100
visibility = ["//visibility:public"],
103101
)
104102

105103
config_setting(
106104
name = "is_py_freethreaded",
107-
flag_values = {
108-
":py_freethreaded": "yes",
109-
},
105+
flag_values = {":py_freethreaded": FreeThreadedFlag.YES},
110106
visibility = ["//visibility:public"],
111107
)
112108

python/private/flags.bzl

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,3 +122,13 @@ PrecompileSourceRetentionFlag = enum(
122122
OMIT_SOURCE = "omit_source",
123123
get_effective_value = _precompile_source_retention_flag_get_effective_value,
124124
)
125+
126+
# Used for matching freethreaded toolchains and would have to be used in wheels
127+
# as well.
128+
# buildifier: disable=name-conventions
129+
FreeThreadedFlag = enum(
130+
# Use freethreaded python toolchain and wheels.
131+
YES = "yes",
132+
# Do not use freethreaded python toolchain and wheels.
133+
NO = "no",
134+
)

0 commit comments

Comments
 (0)