Skip to content

Commit 50980b1

Browse files
committed
Update README, CHANGELOG
1 parent 9ae7af6 commit 50980b1

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,9 @@ END_UNRELEASED_TEMPLATE
118118
Gazelle generates `py_proto_library` rules for `proto_library`. `false` by default.
119119
* (gazelle) New directive `gazelle:python_proto_naming_convention`; controls
120120
naming of `py_proto_library` rules.
121+
* (gazelle) Gazelle now resolves dependencies for `py_proto_library`
122+
module-level imports, i.e. `import some.package.foo_pb2`. Imports of
123+
messages/enums/services inside modules are not yet supported.
121124

122125
{#v0-0-0-removed}
123126
### Removed

gazelle/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ py_proto_library(
288288

289289
The default naming convention is `$proto_name$_pb2_py`, so by default in the above example Gazelle would generate `foo_pb2_py`. Any pre-existing rules are left in place and not renamed.
290290

291-
Note that the Python library will always be imported as `foo_pb2` in Python code, regardless of the naming convention. Also note that Gazelle is currently not able to map said imports, e.g. `import foo_pb2`, to fill in `py_proto_library` targets as dependencies of other rules. See [this issue](https://github.com/bazel-contrib/rules_python/issues/1703).
291+
Note that the Python library will always be imported as `foo_pb2` in Python code, regardless of the naming convention.
292292

293293
#### Directive: `python_default_visibility`:
294294

0 commit comments

Comments
 (0)