Skip to content

Commit 50fb48e

Browse files
authored
fix(pipstar): actually pass the extras down the call stack (#3468)
It seems that the extras were not correctly passed down the call stack. The upstream code was handling everything correctly and we had unit tests for the downstream code. Fixes #3352
1 parent ca2c5b2 commit 50fb48e

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

python/private/pypi/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -433,6 +433,7 @@ bzl_library(
433433
":generate_whl_library_build_bazel_bzl",
434434
":parse_whl_name_bzl",
435435
":patch_whl_bzl",
436+
":pep508_requirement_bzl",
436437
":pypi_repo_utils_bzl",
437438
":whl_metadata_bzl",
438439
":whl_target_platforms_bzl",

python/private/pypi/whl_library.bzl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ load(":deps.bzl", "all_repo_names", "record_files")
2424
load(":generate_whl_library_build_bazel.bzl", "generate_whl_library_build_bazel")
2525
load(":parse_whl_name.bzl", "parse_whl_name")
2626
load(":patch_whl.bzl", "patch_whl")
27+
load(":pep508_requirement.bzl", "requirement")
2728
load(":pypi_repo_utils.bzl", "pypi_repo_utils")
2829
load(":whl_metadata.bzl", "whl_metadata")
2930
load(":whl_target_platforms.bzl", "whl_target_platforms")
@@ -435,6 +436,7 @@ def _whl_library_impl(rctx):
435436
group_deps = rctx.attr.group_deps,
436437
group_name = rctx.attr.group_name,
437438
namespace_package_files = namespace_package_files,
439+
extras = requirement(rctx.attr.requirement).extras,
438440
)
439441
else:
440442
target_platforms = rctx.attr.experimental_target_platforms or []

0 commit comments

Comments
 (0)