Skip to content

Commit 5220b28

Browse files
committed
comment: address most of the comments
1 parent 75c9250 commit 5220b28

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

python/private/sentinel.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def _sentinel_impl(ctx):
2727
_ = ctx # @unused
2828
return [
2929
SentinelInfo(),
30-
# Also output ToolchainInfo
30+
# Also output ToolchainInfo to allow it to be used for noop toolchains
3131
platform_common.ToolchainInfo(),
3232
]
3333

python/uv/private/lock.bzl

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,7 @@ def _lock_impl(ctx):
145145
uv,
146146
python_files,
147147
],
148-
progress_message = "Creating a requirements.txt with uv: //{}:{}".format(
149-
ctx.label.package,
150-
ctx.label.name,
151-
),
148+
progress_message = "Creating a requirements.txt with uv: %{label}",
152149
env = ctx.attr.env,
153150
)
154151

@@ -189,6 +186,8 @@ _python_version_transition = transition(
189186
_lock = rule(
190187
implementation = _lock_impl,
191188
doc = """\
189+
The lock rule that does the locking in a build action (that makes it possible
190+
to use RBE) and also prepares information for a `bazel run` executable rule.
192191
""",
193192
attrs = {
194193
"args": attr.string_list(

tests/uv/lock/lock_tests.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def lock_test_suite(name):
3636
"testdata/build_constraints2.txt",
3737
],
3838
# It seems that the CI remote executors for the RBE do not have network
39-
# connectivity. Is it only our setup or is it a property of RBE?
39+
# connectivity due to current CI setup.
4040
tags = ["no-remote-exec"],
4141
out = "testdata/requirements.txt",
4242
)
@@ -46,7 +46,7 @@ def lock_test_suite(name):
4646
srcs = ["testdata/requirements.in"],
4747
out = "does_not_exist.txt",
4848
# It seems that the CI remote executors for the RBE do not have network
49-
# connectivity. Is it only our setup or is it a property of RBE?
49+
# connectivity due to current CI setup.
5050
tags = ["no-remote-exec"],
5151
)
5252

0 commit comments

Comments
 (0)