Skip to content

Commit 578f66e

Browse files
committed
finish wiring for bzlmod and adjust docs
1 parent 37fe487 commit 578f66e

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ Unreleased changes template.
7373
* {obj}`//python/bin:python`: convenience target for directly running an
7474
interpreter. {obj}`--//python/bin:python_src` can be used to specify a
7575
binary whose interpreter to use.
76+
* (pypi) An extra argument to add the interpreter lib dir to `LDFLAGS` when
77+
building wheels from `sdist`.
7678

7779
{#v0-0-0-removed}
7880
### Removed

python/private/pypi/attrs.bzl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@ ATTRS = {
1818
"add_libdir_to_library_search_path": attr.bool(
1919
default = False,
2020
doc = """
21-
If true, add the lib dir of the bundled interpreter to the library search path via LDFLAGS.
21+
If true, add the lib dir of the bundled interpreter to the library search path via `LDFLAGS`.
22+
23+
:::{versionadded} VERSION_NEXT_FEATURE
24+
:::
2225
""",
2326
),
2427
"download_only": attr.bool(

python/private/pypi/extension.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ def _create_whl_repos(
203203
)
204204
maybe_args = dict(
205205
# The following values are safe to omit if they have false like values
206+
add_libdir_to_library_search_path = pip_attr.add_libdir_to_library_search_path,
206207
annotation = whl_modifications.get(whl_name),
207208
download_only = pip_attr.download_only,
208209
enable_implicit_namespace_pkgs = pip_attr.enable_implicit_namespace_pkgs,

0 commit comments

Comments
 (0)