Skip to content

Commit 5c0ceb4

Browse files
committed
add protobuf dep to py_repositories
1 parent 2722e29 commit 5c0ceb4

File tree

3 files changed

+21
-13
lines changed

3 files changed

+21
-13
lines changed

examples/bzlmod/MODULE.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ local_path_override(
1212
)
1313

1414
# (py_proto_library specific) We are using rules_proto to define rules_proto targets to be consumed by py_proto_library.
15-
bazel_dep(name = "rules_proto", version = "6.0.2")
15+
bazel_dep(name = "rules_proto", version = "6.0.0-rc1")
1616

1717
# (py_proto_library specific) Add the protobuf library for well-known types (e.g. `Any`, `Timestamp`, etc)
1818
bazel_dep(name = "protobuf", version = "27.0", repo_name = "com_google_protobuf")

internal_deps.bzl

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,14 @@ def rules_python_internal_deps():
185185
],
186186
)
187187

188+
# Needed by rules_cc, triggered by @rules_java_builtins from Bazel
189+
http_archive(
190+
name = "protobuf",
191+
sha256 = "da288bf1daa6c04d03a9051781caa52aceb9163586bff9aa6cfb12f69b9395aa",
192+
strip_prefix = "protobuf-27.0",
193+
url = "https://github.com/protocolbuffers/protobuf/releases/download/v27.0/protobuf-27.0.tar.gz",
194+
)
195+
188196
# Needed for stardoc
189197
http_archive(
190198
name = "rules_java",
@@ -234,11 +242,3 @@ def rules_python_internal_deps():
234242
sha256 = "0e124567fa85287874eff33a791c3bbdcc5343329a56faa828ef624380d4607c",
235243
url = "https://github.com/keith/rules_multirun/releases/download/0.9.0/rules_multirun.0.9.0.tar.gz",
236244
)
237-
238-
# Needed by rules_cc, triggered by @rules_java_builtins from Bazel
239-
http_archive(
240-
name = "protobuf",
241-
sha256 = "da288bf1daa6c04d03a9051781caa52aceb9163586bff9aa6cfb12f69b9395aa",
242-
strip_prefix = "protobuf-27.0",
243-
url = "https://github.com/protocolbuffers/protobuf/releases/download/v27.0/protobuf-27.0.tar.gz",
244-
)

python/private/py_repositories.bzl

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,19 @@ def py_repositories():
6060
urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.13/rules_cc-0.0.13.tar.gz"],
6161
)
6262

63-
# Needed by rules_cc, triggerred by @rules_java_prebuilt in Bazel by using @rules_cc//cc:defs.bzl
63+
### Needed by rules_cc, triggerred by @rules_java_prebuilt in Bazel by using @rules_cc//cc:defs.bzl
64+
##http_archive(
65+
## name = "protobuf",
66+
## sha256 = "da288bf1daa6c04d03a9051781caa52aceb9163586bff9aa6cfb12f69b9395aa",
67+
## strip_prefix = "protobuf-29.0",
68+
## url = "https://github.com/protocolbuffers/protobuf/releases/download/v27.0/protobuf-27.0.tar.gz",
69+
##)
6470
http_archive(
6571
name = "protobuf",
66-
sha256 = "da288bf1daa6c04d03a9051781caa52aceb9163586bff9aa6cfb12f69b9395aa",
67-
strip_prefix = "protobuf-27.0",
68-
url = "https://github.com/protocolbuffers/protobuf/releases/download/v27.0/protobuf-27.0.tar.gz",
72+
sha256 = "ce5d00b78450a0ca400bf360ac00c0d599cc225f049d986a27e9a4e396c5a84a",
73+
strip_prefix = "protobuf-29.0-rc2",
74+
urls = [
75+
"https://github.com/protocolbuffers/protobuf/releases/download/v29.0-rc2/protobuf-29.0-rc2.tar.gz",
76+
],
6977
)
7078
pypi_deps()

0 commit comments

Comments
 (0)