Skip to content

Commit 5df2411

Browse files
committed
does not work: remove sorting add topological to depset creation
1 parent 02cae11 commit 5df2411

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

python/private/common.bzl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,8 @@ def _third_party_first(targets):
379379
This is because the DAG is going from first-party deps to third-party deps and usually
380380
no third-party deps include first-party deps.
381381
"""
382-
return sorted(targets, lambda x: PyInfo in x and not x[PyInfo].package)
382+
return targets
383+
# return sorted(targets, lambda x: PyInfo in x and not x[PyInfo].package)
383384

384385
def create_py_info(
385386
ctx,

python/private/py_library.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ def _get_venv_symlinks(ctx, package, version_str):
348348
)
349349
venv_symlinks.append(entry)
350350

351-
return depset(venv_symlinks)
351+
return depset(venv_symlinks, order = "topological")
352352

353353
def _repo_relative_short_path(short_path):
354354
# Convert `../+pypi+foo/some/file.py` to `some/file.py`

0 commit comments

Comments
 (0)