Skip to content

Commit 60d0477

Browse files
Alex Eaglealexeagle
authored andcommitted
lazily call rules_python_external_dependencies
This avoids users having to add a new WORKSPACE dependency call in order to use pip_install
1 parent e821ce9 commit 60d0477

File tree

3 files changed

+4
-14
lines changed

3 files changed

+4
-14
lines changed

WORKSPACE

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@
1414

1515
workspace(name = "rules_python")
1616

17-
load("//python:pip.bzl", "pip_repositories")
18-
19-
pip_repositories()
20-
2117
# Everything below this line is used only for developing rules_python. Users
2218
# should not copy it to their WORKSPACE.
2319

@@ -28,8 +24,3 @@ rules_python_internal_deps()
2824
load("//:internal_setup.bzl", "rules_python_internal_setup")
2925

3026
rules_python_internal_setup()
31-
32-
# TODO(alexeagle): vendor these dependencies so we don't expose new ones to users
33-
load("//experimental/rules_python_external:repositories.bzl", "rules_python_external_dependencies")
34-
35-
rules_python_external_dependencies()

examples/rules_python_external/WORKSPACE

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@ load("@rules_python//python:repositories.bzl", "py_repositories")
1212

1313
py_repositories()
1414

15-
load("@rules_python//experimental/rules_python_external:repositories.bzl", "rules_python_external_dependencies")
16-
17-
rules_python_external_dependencies()
18-
1915
load("@rules_python//experimental/rules_python_external:defs.bzl", "pip_install")
2016

2117
pip_install(

experimental/rules_python_external/defs.bzl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
""
22

3-
load("//experimental/rules_python_external:repositories.bzl", "all_requirements")
3+
load("//experimental/rules_python_external:repositories.bzl", "all_requirements", "rules_python_external_dependencies")
44

55
DEFAULT_REPOSITORY_NAME = "pip"
66

@@ -179,6 +179,9 @@ def pip_install(requirements, name = DEFAULT_REPOSITORY_NAME, **kwargs):
179179
name: A unique name for the created external repository (default 'pip').
180180
**kwargs: Keyword arguments passed directly to the `pip_repository` repository rule.
181181
"""
182+
# Just in case our dependencies weren't already fetched
183+
rules_python_external_dependencies()
184+
182185
pip_repository(
183186
name = name,
184187
requirements = requirements,

0 commit comments

Comments
 (0)