Skip to content

Commit 617e20a

Browse files
committed
comment: revert the making attr public
1 parent 6e7e291 commit 617e20a

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

python/private/config_settings.bzl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ def construct_config_settings(*, name, default_version, versions, minor_mapping,
5555
_python_version_major_minor_flag(
5656
name = _PYTHON_VERSION_MAJOR_MINOR_FLAG.name,
5757
build_setting_default = "",
58-
python_version_flag = _PYTHON_VERSION_FLAG,
5958
visibility = ["//visibility:public"],
6059
)
6160

@@ -153,7 +152,7 @@ _python_version_flag = rule(
153152
)
154153

155154
def _python_version_major_minor_flag_impl(ctx):
156-
input = _flag_value(ctx.attr.python_version_flag)
155+
input = _flag_value(ctx.attr._python_version_flag)
157156
if input:
158157
version = semver(input)
159158
value = "{}.{}".format(version.major, version.minor)
@@ -166,7 +165,7 @@ _python_version_major_minor_flag = rule(
166165
implementation = _python_version_major_minor_flag_impl,
167166
build_setting = config.string(flag = False),
168167
attrs = {
169-
"python_version_flag": attr.label(mandatory = True),
168+
"_python_version_flag": attr.label(default = _PYTHON_VERSION_FLAG),
170169
},
171170
)
172171

0 commit comments

Comments
 (0)