Skip to content

Commit 66b61be

Browse files
Alex Eaglealexeagle
authored andcommitted
move pip_import rule to legacy_pip_import
BREAKING CHANGE: The load statement for "pip_import" and "pip_repositories" has moved to //python/legacy_pip_import:pip.bzl Use of the old load site will print a failure message indicating this.
1 parent c6e6381 commit 66b61be

File tree

21 files changed

+166
-165
lines changed

21 files changed

+166
-165
lines changed

.bazelrc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# This lets us glob() up all the files inside the examples to make them inputs to tests
44
# (Note, we cannot use `common --deleted_packages` because the bazel version command doesn't support it)
55
# To update these lines, run tools/bazel_integration_test/update_deleted_packages.sh
6-
build --deleted_packages=examples/pip/boto,examples/pip/extras,examples/pip/helloworld,examples/pip_install
7-
query --deleted_packages=examples/pip/boto,examples/pip/extras,examples/pip/helloworld,examples/pip_install
6+
build --deleted_packages=examples/legacy_pip_import/boto,examples/legacy_pip_import/extras,examples/legacy_pip_import/helloworld,examples/pip_install
7+
query --deleted_packages=examples/legacy_pip_import/boto,examples/legacy_pip_import/extras,examples/legacy_pip_import/helloworld,examples/pip_install
88

99
test --test_output=errors

examples/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ package(default_visibility = ["//visibility:public"])
1818
licenses(["notice"]) # Apache 2.0
1919

2020
bazel_integration_test(
21-
name = "pip_example",
21+
name = "legacy_pip_import_example",
2222
timeout = "long",
2323
)
2424

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
# pip example
1+
# LEGACY pip example
2+
3+
This feature has been replaced by the pip_install rule, please see the latest release notes to migrate.
24

35
This shows how you can point Bazel at your requirements.txt file to get dependencies automatically installed.
46

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ http_archive(
88
sha256 = "e46612e9bb0dae8745de6a0643be69e8665a03f63163ac6610c210e80d14c3e4",
99
)
1010

11-
load("@rules_python//python:pip.bzl", "pip_import", "pip_repositories")
11+
load("@rules_python//python/legacy_pip_import:pip.bzl", "pip_import", "pip_repositories")
1212

1313
pip_repositories()
1414

File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)