@@ -30,6 +30,7 @@ load(":hub_repository.bzl", "hub_repository", "whl_config_settings_to_json")
30
30
load (":parse_requirements.bzl" , "parse_requirements" )
31
31
load (":parse_whl_name.bzl" , "parse_whl_name" )
32
32
load (":pep508_env.bzl" , "env" )
33
+ load (":pep508_evaluate.bzl" , "evaluate" )
33
34
load (":pip_repository_attrs.bzl" , "ATTRS" )
34
35
load (":python_tag.bzl" , "python_tag" )
35
36
load (":requirements_files_by_platform.bzl" , "requirements_files_by_platform" )
@@ -80,21 +81,27 @@ def _platforms(*, python_version, minor_mapping, config):
80
81
for platform , values in config .platforms .items ():
81
82
# TODO @aignas 2025-07-07: this is probably doing the parsing of the version too
82
83
# many times.
83
- key = "{}{}{}.{}_ {}" .format (
84
+ abi = "{}{}{}.{}" .format (
84
85
python_tag (values .env ["implementation_name" ]),
85
86
python_version .release [0 ],
86
87
python_version .release [1 ],
87
88
python_version .release [2 ],
88
- platform ,
89
89
)
90
+ key = "{}_{}" .format (abi , platform )
91
+
92
+ env_ = env (
93
+ env = values .env ,
94
+ os = values .os_name ,
95
+ arch = values .arch_name ,
96
+ python_version = python_version .string ,
97
+ )
98
+
99
+ if values .marker and not evaluate (values .marker , env = env_ ):
100
+ continue
90
101
91
102
platforms [key ] = struct (
92
- env = env (
93
- env = values .env ,
94
- os = values .os_name ,
95
- arch = values .arch_name ,
96
- python_version = python_version .string ,
97
- ),
103
+ env = env_ ,
104
+ triple = "{}_{}_{}" .format (abi , values .os_name , values .arch_name ),
98
105
whl_abi_tags = [
99
106
v .format (
100
107
major = python_version .release [0 ],
@@ -203,17 +210,19 @@ def _create_whl_repos(
203
210
whl_group_mapping = {}
204
211
requirement_cycles = {}
205
212
213
+ platforms = _platforms (
214
+ python_version = pip_attr .python_version ,
215
+ minor_mapping = minor_mapping ,
216
+ config = config ,
217
+ )
218
+
206
219
if evaluate_markers :
207
220
# This is most likely unit tests
208
221
pass
209
222
elif config .enable_pipstar :
210
223
evaluate_markers = lambda _ , requirements : evaluate_markers_star (
211
224
requirements = requirements ,
212
- platforms = _platforms (
213
- python_version = pip_attr .python_version ,
214
- minor_mapping = minor_mapping ,
215
- config = config ,
216
- ),
225
+ platforms = platforms ,
217
226
)
218
227
else :
219
228
# NOTE @aignas 2024-08-02: , we will execute any interpreter that we find either
@@ -232,7 +241,13 @@ def _create_whl_repos(
232
241
# spin up a Python interpreter.
233
242
evaluate_markers = lambda module_ctx , requirements : evaluate_markers_py (
234
243
module_ctx ,
235
- requirements = requirements ,
244
+ requirements = {
245
+ k : {
246
+ p : platforms [p ].triple
247
+ for p in plats
248
+ }
249
+ for k , plats in requirements .items ()
250
+ },
236
251
python_interpreter = pip_attr .python_interpreter ,
237
252
python_interpreter_target = python_interpreter_target ,
238
253
srcs = pip_attr ._evaluate_markers_srcs ,
@@ -248,18 +263,14 @@ def _create_whl_repos(
248
263
requirements_osx = pip_attr .requirements_darwin ,
249
264
requirements_windows = pip_attr .requirements_windows ,
250
265
extra_pip_args = pip_attr .extra_pip_args ,
251
- platforms = sorted (config . platforms ), # here we only need keys
266
+ platforms = sorted (platforms ), # here we only need keys
252
267
python_version = full_version (
253
268
version = pip_attr .python_version ,
254
269
minor_mapping = minor_mapping ,
255
270
),
256
271
logger = logger ,
257
272
),
258
- platforms = _platforms (
259
- python_version = pip_attr .python_version ,
260
- minor_mapping = minor_mapping ,
261
- config = config ,
262
- ),
273
+ platforms = platforms ,
263
274
extra_pip_args = pip_attr .extra_pip_args ,
264
275
get_index_urls = get_index_urls ,
265
276
evaluate_markers = evaluate_markers ,
@@ -346,6 +357,16 @@ def _create_whl_repos(
346
357
))
347
358
348
359
whl_libraries [repo_name ] = repo .args
360
+ if not config .enable_pipstar and "experimental_target_platforms" in repo .args :
361
+ whl_libraries [repo_name ] |= {
362
+ "experimental_target_platforms" : sorted ({
363
+ # TODO @aignas 2025-07-07: this should be solved in a better way
364
+ platforms [candidate ].triple .partition ("_" )[- 1 ]: None
365
+ for p in repo .args ["experimental_target_platforms" ]
366
+ for candidate in platforms
367
+ if candidate .endswith (p )
368
+ }),
369
+ }
349
370
whl_map .setdefault (whl .name , {})[repo .config_setting ] = repo_name
350
371
351
372
return struct (
@@ -434,14 +455,15 @@ def _configure(
434
455
arch_name ,
435
456
config_settings ,
436
457
env = {},
458
+ marker ,
437
459
whl_abi_tags ,
438
460
whl_platform_tags ,
439
461
override = False ):
440
462
"""Set the value in the config if the value is provided"""
441
463
config .setdefault ("platforms" , {})
442
464
443
465
if platform and (
444
- os_name or arch_name or config_settings or whl_abi_tags or whl_platform_tags or env
466
+ os_name or arch_name or config_settings or whl_abi_tags or whl_platform_tags or env or marker
445
467
):
446
468
if not override and config ["platforms" ].get (platform ):
447
469
return
@@ -455,6 +477,7 @@ def _configure(
455
477
"arch_name" : arch_name ,
456
478
"config_settings" : config_settings ,
457
479
"env" : env ,
480
+ "marker" : marker ,
458
481
"name" : platform .replace ("-" , "_" ).lower (),
459
482
"os_name" : os_name ,
460
483
"whl_abi_tags" : whl_abi_tags ,
@@ -470,7 +493,7 @@ def _configure(
470
493
else :
471
494
config ["platforms" ].pop (platform )
472
495
473
- def _plat (* , name , arch_name , os_name , config_settings = [], env = {}, whl_abi_tags = [], whl_platform_tags = []):
496
+ def _plat (* , name , arch_name , os_name , config_settings = [], env = {}, marker = "" , whl_abi_tags = [], whl_platform_tags = []):
474
497
# NOTE @aignas 2025-07-08: the least preferred is the first item in the list
475
498
if "any" not in whl_platform_tags :
476
499
# the lowest priority one needs to be the first one
@@ -490,6 +513,7 @@ def _plat(*, name, arch_name, os_name, config_settings = [], env = {}, whl_abi_t
490
513
# defaults for env
491
514
"implementation_name" : "cpython" ,
492
515
} | env ,
516
+ marker = marker ,
493
517
whl_abi_tags = whl_abi_tags ,
494
518
whl_platform_tags = whl_platform_tags ,
495
519
)
@@ -524,6 +548,7 @@ def build_config(
524
548
config_settings = tag .config_settings ,
525
549
env = tag .env ,
526
550
os_name = tag .os_name ,
551
+ marker = tag .marker ,
527
552
platform = platform ,
528
553
override = mod .is_root ,
529
554
whl_abi_tags = tag .whl_abi_tags ,
@@ -533,8 +558,6 @@ def build_config(
533
558
# attribute.
534
559
# * for index/downloader config. This includes all of those attributes for
535
560
# overrides, etc. Index overrides per platform could be also used here.
536
- # * for whl selection - selecting preferences of which `platform_tag`s we should use
537
- # for what. We could also model the `cp313t` freethreaded as separate platforms.
538
561
)
539
562
540
563
return struct (
@@ -928,6 +951,12 @@ Supported keys:
928
951
::::{note}
929
952
This is only used if the {envvar}`RULES_PYTHON_ENABLE_PIPSTAR` is enabled.
930
953
::::
954
+ """ ,
955
+ ),
956
+ "marker" : attr .string (
957
+ doc = """\
958
+ A marker which will be evaluated to disable the target platform for certain python versions. This
959
+ is especially useful when defining freethreaded platform variants.
931
960
""" ,
932
961
),
933
962
# The values for PEP508 env marker evaluation during the lock file parsing
0 commit comments