Skip to content

Commit 6a8afa8

Browse files
committed
chore: enable pipstar by default
The most recent improvements to the platform definitions allow us to enable pipstar by default, which means that we can get rid of the interpreter usage in the extension evaluation phase. Fixes #2949
1 parent cc6563e commit 6a8afa8

File tree

4 files changed

+12
-2
lines changed

4 files changed

+12
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,10 @@ END_UNRELEASED_TEMPLATE
7878
platform, consider helping set us up CI for them and update the documentation.
7979
* (ci) We are now testing on Ubuntu 22.04 for RBE and non-RBE configurations.
8080
* (core) #!/usr/bin/env bash is now used as a shebang in the stage1 bootstrap template.
81+
* (pypi) From now on `pipstar` is enabled by default for all builds. To disable it, consider
82+
setting env variable `RULES_PYTHON_ENABLE_PIPSTAR` to `0`. If there are reasons why you have to
83+
keep it disabled, it is a bug and we would like to hear about it, please create a ticket in our
84+
github issue tracker.
8185

8286
{#v0-0-0-fixed}
8387
### Fixed

MODULE.bazel

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,8 @@ pip = use_extension("//python/extensions:pip.bzl", "pip")
109109
],
110110
# We choose the oldest non-EOL version at the time when we release `rules_python`.
111111
# See https://endoflife.date/macos
112+
#
113+
# Keep in sync with "pip_whl_osx_version"
112114
env = {"platform_version": "14.0"},
113115
marker = "python_version >= '3.13'" if freethreaded else "",
114116
os_name = "osx",

python/config_settings/BUILD.bazel

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,11 @@ string_flag(
209209

210210
string_flag(
211211
name = "pip_whl_osx_version",
212-
build_setting_default = "",
212+
# We choose the oldest non-EOL version at the time when we release `rules_python`.
213+
# See https://endoflife.date/macos
214+
#
215+
# Keep in sync with MODULE.bazel
216+
build_setting_default = "14.0",
213217
# NOTE: Only public because it is used in pip hub repos.
214218
visibility = ["//visibility:public"],
215219
)

python/private/internal_config_repo.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ settings for rules to later use.
2121
load(":repo_utils.bzl", "repo_utils")
2222

2323
_ENABLE_PIPSTAR_ENVVAR_NAME = "RULES_PYTHON_ENABLE_PIPSTAR"
24-
_ENABLE_PIPSTAR_DEFAULT = "0"
24+
_ENABLE_PIPSTAR_DEFAULT = "1"
2525
_ENABLE_PYSTAR_ENVVAR_NAME = "RULES_PYTHON_ENABLE_PYSTAR"
2626
_ENABLE_PYSTAR_DEFAULT = "1"
2727
_ENABLE_DEPRECATION_WARNINGS_ENVVAR_NAME = "RULES_PYTHON_DEPRECATION_WARNINGS"

0 commit comments

Comments
 (0)