Skip to content

Commit 7988d44

Browse files
committed
minor: code reshuffling
1 parent 0f83603 commit 7988d44

File tree

1 file changed

+18
-23
lines changed

1 file changed

+18
-23
lines changed

python/private/pypi/extension.bzl

Lines changed: 18 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -97,34 +97,12 @@ def _create_whl_repos(
9797
logger = repo_utils.logger(module_ctx, "pypi:create_whl_repos")
9898
interpreter = hub.detect_interpreter(pip_attr)
9999

100-
# containers to aggregate outputs from this function
101-
extra_aliases = {
102-
whl_name: {alias: True for alias in aliases}
103-
for whl_name, aliases in pip_attr.extra_hub_aliases.items()
104-
}
105-
106100
whl_modifications = {}
107101
if pip_attr.whl_modifications != None:
108102
for mod, whl_name in pip_attr.whl_modifications.items():
109103
whl_modifications[normalize_name(whl_name)] = mod
110104

111-
if pip_attr.experimental_requirement_cycles:
112-
requirement_cycles = {
113-
name: [normalize_name(whl_name) for whl_name in whls]
114-
for name, whls in pip_attr.experimental_requirement_cycles.items()
115-
}
116-
117-
whl_group_mapping = {
118-
whl_name: group_name
119-
for group_name, group_whls in requirement_cycles.items()
120-
for whl_name in group_whls
121-
}
122-
else:
123-
whl_group_mapping = {}
124-
requirement_cycles = {}
125-
126105
platforms = hub.platforms(pip_attr.python_version)
127-
128106
requirements_by_platform = parse_requirements(
129107
module_ctx,
130108
requirements_by_platform = requirements_files_by_platform(
@@ -148,6 +126,20 @@ def _create_whl_repos(
148126
logger = logger,
149127
)
150128

129+
if pip_attr.experimental_requirement_cycles:
130+
requirement_cycles = {
131+
name: [normalize_name(whl_name) for whl_name in whls]
132+
for name, whls in pip_attr.experimental_requirement_cycles.items()
133+
}
134+
135+
whl_group_mapping = {
136+
whl_name: group_name
137+
for group_name, group_whls in requirement_cycles.items()
138+
for whl_name in group_whls
139+
}
140+
else:
141+
whl_group_mapping = {}
142+
requirement_cycles = {}
151143
exposed_packages = {}
152144
for whl in requirements_by_platform:
153145
if whl.is_exposed:
@@ -215,7 +207,10 @@ def _create_whl_repos(
215207

216208
return struct(
217209
exposed_packages = exposed_packages,
218-
extra_aliases = extra_aliases,
210+
extra_aliases = {
211+
whl_name: {alias: True for alias in aliases}
212+
for whl_name, aliases in pip_attr.extra_hub_aliases.items()
213+
},
219214
)
220215

221216
def _whl_repo(

0 commit comments

Comments
 (0)