Skip to content

Commit 7bdd22a

Browse files
committed
Remove extras from whl_repo_name
1 parent 5f386b7 commit 7bdd22a

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

python/private/pypi/whl_repo_name.bzl

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,12 @@
1818
load("//python/private:normalize_name.bzl", "normalize_name")
1919
load(":parse_whl_name.bzl", "parse_whl_name")
2020

21-
def whl_repo_name(filename, sha256, extras):
21+
def whl_repo_name(filename, sha256):
2222
"""Return a valid whl_library repo name given a distribution filename.
2323
2424
Args:
2525
filename: {type}`str` the filename of the distribution.
2626
sha256: {type}`str` the sha256 of the distribution.
27-
extras: {type}`list[str]` the extras for the requirement. TODO(hartikainen): Note sure if this is the right place for extras.
2827
2928
Returns:
3029
a string that can be used in {obj}`whl_library`.
@@ -35,7 +34,6 @@ def whl_repo_name(filename, sha256, extras):
3534
# Then the filename is basically foo-3.2.1.<ext>
3635
name, _, tail = filename.rpartition("-")
3736
parts.append(normalize_name(name))
38-
parts.extend(sorted(extras))
3937
if sha256:
4038
parts.append("sdist")
4139
version = ""
@@ -55,7 +53,6 @@ def whl_repo_name(filename, sha256, extras):
5553
parts.append(python_tag)
5654
parts.append(abi_tag)
5755
parts.append(platform_tag)
58-
parts.extend(sorted(extras))
5956

6057
if sha256:
6158
parts.append(sha256[:8])

0 commit comments

Comments
 (0)