Appease mypy

jsing-canva · jsing-canva · commit 7e48c4e89f23 · 2025-11-06T14:19:17.000+11:00
diff --git a/tests/runfiles/runfiles_test.py b/tests/runfiles/runfiles_test.py
@@ -66,10 +66,12 @@ def testRlocationArgumentValidation(self) -> None:
         )
 
     def testRlocationWithData(self) -> None:
-        rf = runfiles.Create()
-        settings_path = rf.Rlocation(
+        r = runfiles.Create()
+        assert r is not None  # mypy doesn't understand the unittest api.
+        settings_path = r.Rlocation(
             "rules_python/tests/support/current_build_settings.json"
         )
+        assert settings_path is not None
         settings = json.loads(pathlib.Path(settings_path).read_text())
         self.assertIn("bootstrap_impl", settings)
 

Original file line number	Diff line number	Diff line change
`@@ -66,10 +66,12 @@ def testRlocationArgumentValidation(self) -> None:`
`66`	`66`	`)`
`67`	`67`
`68`	`68`	`def testRlocationWithData(self) -> None:`
`69`		`- rf = runfiles.Create()`
`70`		`- settings_path = rf.Rlocation(`
	`69`	`+ r = runfiles.Create()`
	`70`	`+ assert r is not None # mypy doesn't understand the unittest api.`
	`71`	`+ settings_path = r.Rlocation(`
`71`	`72`	`"rules_python/tests/support/current_build_settings.json"`
`72`	`73`	`)`
	`74`	`+ assert settings_path is not None`
`73`	`75`	`settings = json.loads(pathlib.Path(settings_path).read_text())`
`74`	`76`	`self.assertIn("bootstrap_impl", settings)`
`75`	`77`