Review comments:

+ test cases
+ docstring
+ formatting
+ types

Author: dougthor42

tests/tools/wheelmaker_test.py

@@ -4,18 +4,22 @@
 
 
 class ArcNameFromTest(unittest.TestCase):
-
     def test_arcname_from(self) -> None:
-
         # (name, distribution_prefix, strip_path_prefixes, want) tuples
         checks = [
-            ("foo/bar/baz/file.py", "", [], "foo/bar/baz/file.py"),
-            ("foo/bar/baz/file.py", "", ["foo"], "/bar/baz/file.py"),
-            ("foo/bar/baz/file.py", "", ["foo/"], "bar/baz/file.py"),
-            ("foo/bar/baz/file.py", "", ["foo/bar"], "/baz/file.py"),
-            ("foo/bar/baz/file.py", "", ["foo/bar", "baz"], "/baz/file.py"),
-            ("foo/bar/baz/file.py", "", ["foo", "bar"], "/bar/baz/file.py"),
-            ("foo/bar/baz/file.py", "", ["baz", "foo/bar"], "/baz/file.py"),
+            ("a/b/c/file.py", "", [], "a/b/c/file.py"),
+            ("a/b/c/file.py", "", ["a"], "/b/c/file.py"),
+            ("a/b/c/file.py", "", ["a/b/"], "c/file.py"),
+            # only first found is used and it's not cumulative.
+            ("a/b/c/file.py", "", ["a/", "b/"], "b/c/file.py"),
+            # Examples from docs
+            ("foo/bar/baz/file.py", "", ["foo", "foo/bar/baz"], "/bar/baz/file.py"),
+            ("foo/bar/baz/file.py", "", ["foo/bar/baz", "foo"], "/file.py"),
+            ("foo/file2.py", "", ["foo/bar/baz", "foo"], "/file2.py"),
+            # Files under the distribution prefix (eg mylib-1.0.0-dist-info)
+            # are unmodified
+            ("mylib-0.0.1-dist-info/WHEEL", "mylib", [], "mylib-0.0.1-dist-info/WHEEL"),
+            ("mylib/a/b/c/WHEEL", "mylib", ["mylib"], "mylib/a/b/c/WHEEL"),
         ]
         for name, prefix, strip, want in checks:
             with self.subTest(

tools/wheelmaker.py

@@ -24,6 +24,7 @@
 import stat
 import sys
 import zipfile
+from collections.abc import Iterable
 from pathlib import Path
 
 _ZIP_EPOCH = (1980, 1, 1, 0, 0, 0)
@@ -99,8 +100,17 @@ def normalize_pep440(version):
 
 
 def arcname_from(
-    name: str, distribution_prefix: str, strip_path_prefixes: list[str] | None = None
-):
+    name: str, distribution_prefix: str, strip_path_prefixes: Sequence[str] = ()
+) -> str:
+    """Return the within-archive name for a given file path name.
+
+    Prefixes to strip are checked in order and only the first match will be used.
+
+    Args:
+        name: The file path eg 'mylib/a/b/c/file.py'
+        distribution_prefix: The
+        strip_path_prefixes: Remove these prefixes from names.
+    """
     # Always use unix path separators.
     normalized_arcname = name.replace(os.path.sep, "/")
     # Don't manipulate names filenames in the .distinfo or .data directories.