Skip to content

Commit 8d86ecb

Browse files
committed
Revert "full fix"
This reverts commit b7122ce.
1 parent b7122ce commit 8d86ecb

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

CHANGELOG.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,6 @@ END_UNRELEASED_TEMPLATE
8686

8787
{#v0-0-0-fixed}
8888
### Fixed
89-
* (bootstrap) The stage1 bootstrap script now correctly handles nested `RUNFILES_DIR`
90-
environments, fixing issues where a `py_binary` calls another `py_binary`
91-
([#3187](https://github.com/bazel-contrib/rules_python/issues/3187)).
9289
* (pypi) Fixes an issue where builds using a `bazel vendor` vendor directory
9390
would fail if the constraints file contained environment markers. Fixes
9491
[#2996](https://github.com/bazel-contrib/rules_python/issues/2996).

python/private/python_bootstrap_template.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -516,6 +516,7 @@ def Main():
516516
if os.environ.get("RULES_PYTHON_TESTING_TELL_MODULE_SPACE"):
517517
new_env["RULES_PYTHON_TESTING_MODULE_SPACE"] = module_space
518518

519+
print(f"===== module space: {module_space}")
519520
python_imports = '%imports%'
520521
python_path_entries = CreatePythonPathEntries(python_imports, module_space)
521522
python_path_entries += GetRepositoriesImports(module_space, %import_all%)
@@ -538,6 +539,7 @@ def Main():
538539
new_env['PYTHONPATH'] = python_path
539540
runfiles_envkey, runfiles_envvalue = RunfilesEnvvar(module_space)
540541
if runfiles_envkey:
542+
print(f"===== setting {runfiles_envkey} = {runfiles_envvalue}")
541543
new_env[runfiles_envkey] = runfiles_envvalue
542544

543545
# Don't prepend a potentially unsafe path to sys.path

python/private/stage1_bootstrap_template.sh

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,6 @@ else
7070
maybe_root="${RUNFILES_MANIFEST_FILE%%.runfiles/MANIFEST}.runfiles"
7171
fi
7272

73-
# The RUNFILES_DIR et al variables may misreport the runfiles directory
74-
# if an outer binary invokes this binary when it isn't a data dependency.
75-
# e.g. a genrule calls `bazel-bin/outer --inner=bazel-bin/inner`
7673
if [[ -n "$maybe_root" && -e "$maybe_root/$STAGE2_BOOTSTRAP" ]]; then
7774
echo "$maybe_root"
7875
return 0
@@ -105,9 +102,6 @@ else
105102
RUNFILES_DIR=$(find_runfiles_root $0)
106103
fi
107104

108-
if [[ -n "$RULES_PYTHON_TESTING_TELL_MODULE_SPACE" ]]; then
109-
export RULES_PYTHON_TESTING_MODULE_SPACE="$RUNFILES_DIR"
110-
fi
111105

112106
function find_python_interpreter() {
113107
runfiles_root="$1"

tests/bootstrap_impls/BUILD.bazel

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,10 @@ sh_py_run_test(
101101
bootstrap_impl = "script",
102102
py_src = "bin.py",
103103
sh_src = "run_binary_find_runfiles_test.sh",
104-
target_compatible_with = SUPPORTS_BOOTSTRAP_SCRIPT,
104+
target_compatible_with = select({
105+
"@platforms//os:windows": ["@platforms//:incompatible"],
106+
"//conditions:default": [],
107+
}),
105108
)
106109

107110
py_reconfig_test(

0 commit comments

Comments
 (0)