Skip to content

Commit 913fba9

Browse files
committed
refactor
1 parent 47e81a1 commit 913fba9

File tree

2 files changed

+18
-26
lines changed

2 files changed

+18
-26
lines changed

examples/bzlmod/MODULE.bazel.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

python/private/pypi/render_pkg_aliases.bzl

Lines changed: 16 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -61,41 +61,33 @@ If the value is missing, then the "default" Python version is being used,
6161
which has a "null" version value and will not match version constraints.
6262
"""
6363

64-
def _render_pkg_aliases(name, actual, group_name, extra_aliases):
64+
def _repr_actual(actual):
6565
if len(actual) == 1 and None in actual:
66-
actual = repr(actual.values()[0])
66+
return repr(actual.values()[0])
6767
else:
68-
actual = render.indent(render.dict(actual)).lstrip()
68+
return render.indent(render.dict(actual)).lstrip()
6969

70+
def _render_common_aliases(*, name, aliases, extra_aliases = [], group_name = None):
7071
return """\
72+
load("@rules_python//python/private/pypi:pkg_aliases.bzl", "pkg_aliases")
73+
74+
package(default_visibility = ["//visibility:public"])
75+
7176
pkg_aliases(
7277
name = "{name}",
7378
actual = {actual},
7479
group_name = {group_name},
7580
extra_aliases = {extra_aliases},
76-
)""".format(name = name, actual = actual, group_name = repr(group_name), extra_aliases = repr(extra_aliases))
77-
78-
def _render_common_aliases(*, name, aliases, extra_aliases = [], group_name = None):
79-
lines = [
80-
"""\
81-
load("@rules_python//python/private/pypi:pkg_aliases.bzl", "pkg_aliases")""",
82-
"""package(default_visibility = ["//visibility:public"])""",
83-
]
84-
85-
lines.append(
86-
_render_pkg_aliases(
87-
name = name,
88-
actual = {
89-
a.config_setting: a.repo
90-
for a in aliases
91-
},
92-
group_name = group_name,
93-
extra_aliases = extra_aliases,
94-
),
81+
)""".format(
82+
name = name,
83+
actual = _repr_actual({
84+
a.config_setting: a.repo
85+
for a in aliases
86+
}),
87+
group_name = repr(group_name),
88+
extra_aliases = repr(extra_aliases),
9589
)
9690

97-
return "\n\n".join(lines)
98-
9991
def render_pkg_aliases(*, aliases, requirement_cycles = None, extra_hub_aliases = {}):
10092
"""Create alias declarations for each PyPI package.
10193

0 commit comments

Comments
 (0)