Make lazily fetching dependencies compatible to disallow_empty_glob (#477)

martis42 · Jonathon Belotti · web-flow · commit 915f21b94617 · 2021-06-08T18:45:56.000-07:00
Some python packages are provided as ".tar.gz" instead of ".whl".
In such cases globbing for ".whl" files returns an empty result.

Co-authored-by: Jonathon Belotti &lt;jonathon@canva.com&gt;
diff --git a/python/pip_install/extract_wheels/lib/bazel.py b/python/pip_install/extract_wheels/lib/bazel.py
@@ -39,7 +39,7 @@ def generate_build_file_contents(
 
         filegroup(
             name="{whl_file_label}",
-            srcs=glob(["*.whl"]),
+            srcs=glob(["*.whl"], allow_empty = True),
             data=[{whl_file_deps}]
         )
 

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ def generate_build_file_contents(`
`39`	`39`
`40`	`40`	`filegroup(`
`41`	`41`	`name="{whl_file_label}",`
`42`		`- srcs=glob(["*.whl"]),`
	`42`	`+ srcs=glob(["*.whl"], allow_empty = True),`
`43`	`43`	`data=[{whl_file_deps}]`
`44`	`44`	`)`
`45`	`45`