Skip to content

Commit 935e4f0

Browse files
committed
fixup tests
1 parent dbc046e commit 935e4f0

File tree

2 files changed

+13
-19
lines changed

2 files changed

+13
-19
lines changed

python/private/pypi/whl_library_targets.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ def _config_settings(dependencies_by_platform, native = native, **kwargs):
384384

385385
if abi:
386386
_kwargs["flag_values"] = {
387-
str(Label("//python/config_settings:python_version")): "3.{}".format(abi[len("cp3"):]),
387+
Label("//python/config_settings:python_version"): "3.{}".format(abi[len("cp3"):]),
388388
}
389389

390390
native.config_setting(

tests/pypi/whl_library_targets/whl_library_targets_tests.bzl

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,8 @@ def _test_platforms(env):
6868
"@//python/config_settings:is_python_3.9": ["py39_dep"],
6969
"@platforms//cpu:aarch64": ["arm_dep"],
7070
"@platforms//os:windows": ["win_dep"],
71+
"cp310.11_linux_ppc64le": ["full_version_dep"],
7172
"cp310_linux_ppc64le": ["py310_linux_ppc64le_dep"],
72-
"cp39_anyos_aarch64": ["py39_arm_dep"],
73-
"cp39_linux_anyarch": ["py39_linux_dep"],
7473
"linux_x86_64": ["linux_intel_dep"],
7574
},
7675
filegroups = {},
@@ -82,39 +81,34 @@ def _test_platforms(env):
8281

8382
env.expect.that_collection(calls).contains_exactly([
8483
{
85-
"name": "is_python_3.10_linux_ppc64le",
86-
"flag_values": {
87-
"@rules_python//python/config_settings:python_version_major_minor": "3.10",
88-
},
84+
"name": "is_python_3.10.11_linux_ppc64le",
85+
"visibility": ["//visibility:private"],
8986
"constraint_values": [
9087
"@platforms//cpu:ppc64le",
9188
"@platforms//os:linux",
9289
],
93-
"visibility": ["//visibility:private"],
94-
},
95-
{
96-
"name": "is_python_3.9_anyos_aarch64",
9790
"flag_values": {
98-
"@rules_python//python/config_settings:python_version_major_minor": "3.9",
91+
Label("//python/config_settings:python_version"): "3.10.11",
9992
},
100-
"constraint_values": ["@platforms//cpu:aarch64"],
101-
"visibility": ["//visibility:private"],
10293
},
10394
{
104-
"name": "is_python_3.9_linux_anyarch",
95+
"name": "is_python_3.10_linux_ppc64le",
96+
"visibility": ["//visibility:private"],
97+
"constraint_values": [
98+
"@platforms//cpu:ppc64le",
99+
"@platforms//os:linux",
100+
],
105101
"flag_values": {
106-
"@rules_python//python/config_settings:python_version_major_minor": "3.9",
102+
Label("//python/config_settings:python_version"): "3.10",
107103
},
108-
"constraint_values": ["@platforms//os:linux"],
109-
"visibility": ["//visibility:private"],
110104
},
111105
{
112106
"name": "is_linux_x86_64",
107+
"visibility": ["//visibility:private"],
113108
"constraint_values": [
114109
"@platforms//cpu:x86_64",
115110
"@platforms//os:linux",
116111
],
117-
"visibility": ["//visibility:private"],
118112
},
119113
]) # buildifier: @unsorted-dict-items
120114

0 commit comments

Comments
 (0)