Skip to content

Commit 98cffb6

Browse files
mai93mai93
committed
apply review comments -1
1 parent c0bdbfb commit 98cffb6

File tree

3 files changed

+64
-62
lines changed

3 files changed

+64
-62
lines changed

‎CHANGELOG.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@ END_UNRELEASED_TEMPLATE
8484
when the APIs get removed. If you need to customize the way the dependencies get
8585
evaluated, see [our docs](/pypi/download.html#customizing-requires-dist-resolution) on customizing `Requires-Dist` resolution.
8686
* (toolchains) Added Python version 3.14.0.
87+
* (deps) (bzlmod) Upgraded to `bazel-skylib` version
88+
[1.8.2](https://github.com/bazelbuild/bazel-skylib/releases/tag/1.8.2)
8789

8890
{#v0-0-0-fixed}
8991
### Fixed

‎MODULE.bazel‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ module(
55
)
66

77
bazel_dep(name = "bazel_features", version = "1.21.0")
8-
bazel_dep(name = "bazel_skylib", version = "1.8.1")
8+
bazel_dep(name = "bazel_skylib", version = "1.8.2")
99
bazel_dep(name = "rules_cc", version = "0.1.5")
1010
bazel_dep(name = "platforms", version = "0.0.11")
1111

‎examples/build_file_generation/WORKSPACE‎

Lines changed: 61 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -7,67 +7,7 @@ workspace(name = "build_file_generation_example")
77
# file. When the symbol is loaded you can use the rule.
88
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
99

10-
######################################################################
11-
# We need rules_go and bazel_gazelle, to build the gazelle plugin from source.
12-
# Setup instructions for this section are at
13-
# https://github.com/bazelbuild/bazel-gazelle#running-gazelle-with-bazel
14-
# You may need to update the version of the rule, which is listed in the above
15-
# documentation.
16-
######################################################################
17-
18-
# Define an http_archive rule that will download the below ruleset,
19-
# test the sha, and extract the ruleset to you local bazel cache.
20-
21-
http_archive(
22-
name = "bazel_skylib",
23-
sha256 = "6e78f0e57de26801f6f564fa7c4a48dc8b36873e416257a92bbb0937eeac8446",
24-
urls = [
25-
"https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.8.2/bazel-skylib-1.8.2.tar.gz",
26-
"https://github.com/bazelbuild/bazel-skylib/releases/download/1.8.2/bazel-skylib-1.8.2.tar.gz",
27-
],
28-
)
29-
30-
load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")
31-
32-
bazel_skylib_workspace()
33-
34-
http_archive(
35-
name = "io_bazel_rules_go",
36-
sha256 = "9d72f7b8904128afb98d46bbef82ad7223ec9ff3718d419afb355fddd9f9484a",
37-
urls = [
38-
"https://mirror.bazel.build/github.com/bazel-contrib/rules_go/releases/download/v0.55.1/rules_go-v0.55.1.zip",
39-
"https://github.com/bazel-contrib/rules_go/releases/download/v0.55.1/rules_go-v0.55.1.zip",
40-
],
41-
)
42-
43-
# Download the bazel_gazelle ruleset.
44-
http_archive(
45-
name = "bazel_gazelle",
46-
sha256 = "75df288c4b31c81eb50f51e2e14f4763cb7548daae126817247064637fd9ea62",
47-
urls = [
48-
"https://mirror.bazel.build/github.com/bazelbuild/bazel-gazelle/releases/download/v0.36.0/bazel-gazelle-v0.36.0.tar.gz",
49-
"https://github.com/bazelbuild/bazel-gazelle/releases/download/v0.36.0/bazel-gazelle-v0.36.0.tar.gz",
50-
],
51-
)
52-
53-
# Load rules_go ruleset and expose the toolchain and dep rules.
54-
load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")
55-
load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")
56-
57-
# go_rules_dependencies is a function that registers external dependencies
58-
# needed by the Go rules.
59-
# See: https://github.com/bazelbuild/rules_go/blob/master/go/dependencies.rst#go_rules_dependencies
60-
go_rules_dependencies()
61-
62-
# go_rules_dependencies is a function that registers external dependencies
63-
# needed by the Go rules.
64-
# See: https://github.com/bazelbuild/rules_go/blob/master/go/dependencies.rst#go_rules_dependencies
65-
go_register_toolchains(version = "1.21.13")
66-
67-
# The following call configured the gazelle dependencies, Go environment and Go SDK.
68-
gazelle_dependencies()
69-
70-
# Remaining setup is for rules_python.
10+
# Setup rules_python.
7111

7212
# DON'T COPY_PASTE THIS.
7313
# Our example uses `local_repository` to point to the HEAD version of rules_python.
@@ -137,6 +77,66 @@ load("@pip//:requirements.bzl", "install_deps")
13777
# Initialize repositories for all packages in requirements_lock.txt.
13878
install_deps()
13979

80+
######################################################################
81+
# We need rules_go and bazel_gazelle, to build the gazelle plugin from source.
82+
# Setup instructions for this section are at
83+
# https://github.com/bazelbuild/bazel-gazelle#running-gazelle-with-bazel
84+
# You may need to update the version of the rule, which is listed in the above
85+
# documentation.
86+
######################################################################
87+
88+
# Define an http_archive rule that will download the below ruleset,
89+
# test the sha, and extract the ruleset to you local bazel cache.
90+
91+
http_archive(
92+
name = "bazel_skylib",
93+
sha256 = "6e78f0e57de26801f6f564fa7c4a48dc8b36873e416257a92bbb0937eeac8446",
94+
urls = [
95+
"https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.8.2/bazel-skylib-1.8.2.tar.gz",
96+
"https://github.com/bazelbuild/bazel-skylib/releases/download/1.8.2/bazel-skylib-1.8.2.tar.gz",
97+
],
98+
)
99+
100+
load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")
101+
102+
bazel_skylib_workspace()
103+
104+
http_archive(
105+
name = "io_bazel_rules_go",
106+
sha256 = "9d72f7b8904128afb98d46bbef82ad7223ec9ff3718d419afb355fddd9f9484a",
107+
urls = [
108+
"https://mirror.bazel.build/github.com/bazel-contrib/rules_go/releases/download/v0.55.1/rules_go-v0.55.1.zip",
109+
"https://github.com/bazel-contrib/rules_go/releases/download/v0.55.1/rules_go-v0.55.1.zip",
110+
],
111+
)
112+
113+
# Download the bazel_gazelle ruleset.
114+
http_archive(
115+
name = "bazel_gazelle",
116+
sha256 = "75df288c4b31c81eb50f51e2e14f4763cb7548daae126817247064637fd9ea62",
117+
urls = [
118+
"https://mirror.bazel.build/github.com/bazelbuild/bazel-gazelle/releases/download/v0.36.0/bazel-gazelle-v0.36.0.tar.gz",
119+
"https://github.com/bazelbuild/bazel-gazelle/releases/download/v0.36.0/bazel-gazelle-v0.36.0.tar.gz",
120+
],
121+
)
122+
123+
# Load rules_go ruleset and expose the toolchain and dep rules.
124+
load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")
125+
load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")
126+
127+
# go_rules_dependencies is a function that registers external dependencies
128+
# needed by the Go rules.
129+
# See: https://github.com/bazelbuild/rules_go/blob/master/go/dependencies.rst#go_rules_dependencies
130+
go_rules_dependencies()
131+
132+
# go_rules_dependencies is a function that registers external dependencies
133+
# needed by the Go rules.
134+
# See: https://github.com/bazelbuild/rules_go/blob/master/go/dependencies.rst#go_rules_dependencies
135+
go_register_toolchains(version = "1.21.13")
136+
137+
# The following call configured the gazelle dependencies, Go environment and Go SDK.
138+
gazelle_dependencies()
139+
140140
# The rules_python gazelle extension has some third-party go dependencies
141141
# which we need to fetch in order to compile it.
142142
load("@rules_python_gazelle_plugin//:deps.bzl", _py_gazelle_deps = "gazelle_deps")

0 commit comments

Comments
 (0)