You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docs: describe annotations attr of pip_parse (#1667)
My default expectation would be that the keys to the `annotations`
dictionary passed to `pip_parse` would use the `normalize_name(...)`
convention, as is used elsewhere in the API. However, this does not
appear to be the case. I originally was going to file a bug, but maybe
just documenting the current behavior is enough?
For a minimal repro showing that this capitalization is indeed required,
see https://github.com/bruno-digitbio/bug-rules-python-annotation-pyqt
In that repo,
```bash
$ bazel run //:test_has_comment
$ tail $(bazel info output_base)/external/pip_pyqt6/BUILD.bazel
$ tail $(bazel info output_base)/external/pip_wheel/BUILD.bazel
```
will both show `# A comment` at the bottom, as requested in the
`WORKSPACE` file. However, if you first run
```bash
$ bazel run //:requirements.update
```
then the auto-generated requirements file will use lowercase for the
requirement specification, breaking the desired behavior.
Please let me know if it makes more sense to just check in the docs,
include this example (or something similar) as a small test, or
something else. Apologies if I missed anything in the contribution
guidelines!
0 commit comments