Skip to content

Commit a4566b1

Browse files
committed
remove lower tier platforms from pip.default testing
1 parent a9c2aaa commit a4566b1

File tree

2 files changed

+25
-25
lines changed

2 files changed

+25
-25
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,10 @@ END_UNRELEASED_TEMPLATE
6767
* 3.12.11
6868
* 3.14.0b3
6969
* (toolchain) Python 3.13 now references 3.13.5
70+
* (pypi) From now on the list of default platforms only includes `linux_x86_64`, `linux_aarch64`,
71+
`osx_x86_64`, `osx_aarch64` and `windows_x86_64`. If you are on other platforms, you need to
72+
use the `pip.default` to configure it yourself. If you are interested in graduating the
73+
platform, consider helping set us up CI for them and update the documentation.
7074

7175
{#v0-0-0-fixed}
7276
### Fixed

MODULE.bazel

Lines changed: 21 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,6 @@ pip = use_extension("//python/extensions:pip.bzl", "pip")
8787
for cpu in [
8888
"x86_64",
8989
"aarch64",
90-
# TODO @aignas 2025-05-19: only leave tier 0-1 cpus when stabilizing the
91-
# `pip.default` extension. i.e. drop the below values - users will have to
92-
# define themselves if they need them.
93-
"arm",
94-
"ppc",
95-
"s390x",
9690
]
9791
]
9892

@@ -123,29 +117,31 @@ pip = use_extension("//python/extensions:pip.bzl", "pip")
123117
"universal2",
124118
"arm64",
125119
],
126-
"x86_64": [
127-
"universal2",
128-
"x86_64",
120+
}.items()
121+
]
122+
123+
[
124+
pip.default(
125+
arch_name = cpu,
126+
config_settings = [
127+
"@platforms//cpu:{}".format(cpu),
128+
"@platforms//os:windows",
129129
],
130+
env = {"platform_version": "0"},
131+
os_name = "windows",
132+
platform = "windows_{}".format(cpu),
133+
whl_abi_tags = [
134+
"cp{major}{minor}",
135+
"abi3",
136+
"none",
137+
],
138+
whl_platform_tags = whl_platform_tags,
139+
)
140+
for cpu, whl_platform_tags in {
141+
"x86_64": ["win_amd64"],
130142
}.items()
131143
]
132144

133-
pip.default(
134-
arch_name = "x86_64",
135-
config_settings = [
136-
"@platforms//cpu:x86_64",
137-
"@platforms//os:windows",
138-
],
139-
env = {"platform_version": "0"},
140-
os_name = "windows",
141-
platform = "windows_x86_64",
142-
whl_abi_tags = [
143-
"cp{major}{minor}",
144-
"abi3",
145-
"none",
146-
],
147-
whl_platform_tags = ["win_amd64"],
148-
)
149145
pip.parse(
150146
# NOTE @aignas 2024-10-26: We have an integration test that depends on us
151147
# being able to build sdists for this hub, so explicitly set this to False.

0 commit comments

Comments
 (0)