Skip to content

Commit a599030

Browse files
Apply suggestions from code review
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 9c36859 commit a599030

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

docs/howto/common-deps-with-multipe-pypi-versions.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ PyPI hub name)? Stated as code, this situation:
88
```bzl
99

1010
py_binary(
11-
name = "bin_alpha"
11+
name = "bin_alpha",
1212
deps = ["@pypi_alpha//requests", ":common"],
1313
)
1414
py_binary(
15-
name = "bin_alpha"
15+
name = "bin_beta",
1616
deps = ["@pypi_beta//requests", ":common"],
1717
)
1818

@@ -37,7 +37,7 @@ to pick different dependencies.
3737
# File: MODULE.bazel
3838
3939
rules_python_config.add_transition_setting(
40-
setting = "@//pick:pypi_hub",
40+
setting = "//:pypi_hub",
4141
)
4242
4343
# File: BUILD.bazel
@@ -66,15 +66,15 @@ py_binary(
6666
config_settings = {
6767
"//:pypi_hub": "alpha",
6868
},
69-
deps ["@pypi_alpha//requests", ":common"],
69+
deps = ["@pypi_alpha//requests", ":common"],
7070
)
7171
py_binary(
7272
name = "bin_beta",
7373
srcs = ["bin_beta.py"],
7474
config_settings = {
7575
"//:pypi_hub": "beta",
7676
},
77-
deps ["@pypi_beta//requests", ":common"],
77+
deps = ["@pypi_beta//requests", ":common"],
7878
)
7979
py_library(
8080
name = "common",

python/private/common_labels.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"""Constants for common labels used in the codebase."""
22

3-
# NOTE: str() is called becomes some APIs don't accept Label objects
3+
# NOTE: str() is called because some APIs don't accept Label objects
44
# (e.g. transition inputs/outputs or the transition settings return dict)
55

66
labels = struct(

0 commit comments

Comments
 (0)