Skip to content

Commit a61e676

Browse files
committed
fixup
1 parent af68cce commit a61e676

File tree

4 files changed

+5
-11
lines changed

4 files changed

+5
-11
lines changed

examples/pip_parse_vendored/requirements.bzl

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"""
55

66
load("@rules_python//python:pip.bzl", "pip_utils")
7-
load("@rules_python//python/pip_install:pip_repository.bzl", "group_library", "whl_config_repository", "whl_library")
7+
load("@rules_python//python/pip_install:pip_repository.bzl", "whl_config_repository", "whl_library")
88

99
all_requirements = [
1010
"@my_project_pip_deps_vendored_certifi//:pkg",
@@ -91,16 +91,11 @@ def install_deps(**whl_library_kwargs):
9191
for requirement in group_requirements
9292
}
9393

94-
group_repo = "my_project_pip_deps_vendored__config"
95-
group_library(
96-
name = group_repo,
97-
repo_prefix = "my_project_pip_deps_vendored_",
98-
groups = all_requirement_groups,
99-
)
100-
10194
config_repo = "my_project_pip_deps_vendored__config"
10295
whl_config_repository(
10396
name = config_repo,
97+
repo_prefix = "my_project_pip_deps_vendored_",
98+
groups = all_requirement_groups,
10499
whl_map = {
105100
p: ""
106101
for p in all_whl_requirements_by_package

python/pip_install/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ bzl_library(
2222
name = "pip_repository_bzl",
2323
srcs = ["pip_repository.bzl"],
2424
deps = [
25-
"//python/private/pypi:group_library_bzl",
2625
"//python/private/pypi:package_annotation_bzl",
2726
"//python/private/pypi:pip_repository_bzl",
27+
"//python/private/pypi:whl_config_library_bzl",
2828
"//python/private/pypi:whl_library_bzl",
2929
],
3030
)

python/private/pypi/pip_repository.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ def _pip_repository_impl(rctx):
156156
imports = [
157157
# NOTE: Maintain the order consistent with `buildifier`
158158
'load("@rules_python//python:pip.bzl", "pip_utils")',
159-
'load("@rules_python//python/pip_install:pip_repository.bzl", "group_library", "whl_config_repository", "whl_library")',
159+
'load("@rules_python//python/pip_install:pip_repository.bzl", "whl_config_repository", "whl_library")',
160160
]
161161

162162
annotations = {}

python/private/pypi/whl_config_repository.bzl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ whl_config_repository = repository_rule(
2727
doc = "Prefix used for the whl_library created components of each group",
2828
),
2929
"whl_map": attr.string_dict(
30-
mandatory = True,
3130
doc = """\
3231
The wheel map where values are json.encoded strings of the whl_map constructed
3332
in the pip.parse tag class.

0 commit comments

Comments
 (0)