Skip to content

Commit a9cf358

Browse files
committed
refactor: cleanup the call to create whl_repos
1 parent 6a8913c commit a9cf358

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

examples/bzlmod/MODULE.bazel.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

python/private/pypi/extension.bzl

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -459,24 +459,26 @@ You cannot use both the additive_build_content and additive_build_content_file a
459459
parallel_download = pip_attr.parallel_download,
460460
)
461461

462+
requirements_by_platform = requirements_files_by_platform(
463+
requirements_by_platform = pip_attr.requirements_by_platform,
464+
requirements_linux = pip_attr.requirements_linux,
465+
requirements_lock = pip_attr.requirements_lock,
466+
requirements_osx = pip_attr.requirements_darwin,
467+
requirements_windows = pip_attr.requirements_windows,
468+
extra_pip_args = pip_attr.extra_pip_args,
469+
python_version = _major_minor_version(pip_attr.python_version),
470+
logger = repo_utils.logger(module_ctx, "pypi:requirements_files_by_platform"),
471+
)
472+
462473
result = _create_whl_repos(
463474
module_ctx,
464475
pip_attr = struct(
465-
requirements_by_platform = requirements_files_by_platform(
466-
requirements_by_platform = pip_attr.requirements_by_platform,
467-
requirements_linux = pip_attr.requirements_linux,
468-
requirements_lock = pip_attr.requirements_lock,
469-
requirements_osx = pip_attr.requirements_darwin,
470-
requirements_windows = pip_attr.requirements_windows,
471-
extra_pip_args = pip_attr.extra_pip_args,
472-
python_version = _major_minor_version(pip_attr.python_version),
473-
logger = repo_utils.logger(module_ctx, "pypi:requirements_files_by_platform"),
474-
),
475476
auth_patterns = pip_attr.auth_patterns,
476477
download_only = pip_attr.download_only,
477478
enable_implicit_namespace_pkgs = pip_attr.enable_implicit_namespace_pkgs,
478479
environment = pip_attr.environment,
479480
envsubst = pip_attr.envsubst,
481+
evaluate_markers_srcs = pip_attr._evaluate_markers_srcs,
480482
experimental_requirement_cycles = pip_attr.experimental_requirement_cycles,
481483
experimental_target_platforms = pip_attr.experimental_target_platforms,
482484
extra_pip_args = pip_attr.extra_pip_args,
@@ -488,9 +490,9 @@ You cannot use both the additive_build_content and additive_build_content_file a
488490
python_interpreter_target = pip_attr.python_interpreter_target,
489491
python_version = pip_attr.python_version,
490492
quiet = pip_attr.quiet,
493+
requirements_by_platform = requirements_by_platform,
491494
timeout = pip_attr.timeout,
492495
whl_modifications = pip_attr.whl_modifications,
493-
evaluate_markers_srcs = pip_attr._evaluate_markers_srcs,
494496
),
495497
whl_overrides = whl_overrides,
496498
get_index_urls = get_index_urls,

0 commit comments

Comments
 (0)