Skip to content

Commit aff33e5

Browse files
committed
Set incompatible_strict_action_env and announce_rc in CI
1 parent 029a4dc commit aff33e5

File tree

4 files changed

+12
-1
lines changed

4 files changed

+12
-1
lines changed

.bazelci/presubmit.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ buildifier:
3434
build_flags:
3535
- "--keep_going"
3636
- "--build_tag_filters=-integration-test"
37+
- "--announce_rc"
3738
test_targets:
3839
- "--"
3940
- "..."
@@ -500,10 +501,14 @@ tasks:
500501
<<: *common_bazelinbazel_config
501502
name: "tests/integration bazel-in-bazel: Ubuntu"
502503
platform: ubuntu2204
504+
build_flags:
505+
- "--action_env=PATH"
503506
integration_test_bazelinbazel_debian:
504507
<<: *common_bazelinbazel_config
505508
name: "tests/integration bazel-in-bazel: Debian"
506509
platform: debian11
510+
build_flags:
511+
- "--action_env=PATH"
507512
# The bazelinbazel tests were disabled on Mac to save CI jobs slots, and
508513
# have bitrotted a bit. For now, just run a subset of what we're most
509514
# interested in.
@@ -513,6 +518,8 @@ tasks:
513518
platform: macos
514519
build_targets: ["//tests/integration:local_toolchains_test_bazel_self"]
515520
test_targets: ["//tests/integration:local_toolchains_test_bazel_self"]
521+
build_flags:
522+
- "--action_env=PATH"
516523
# The bazelinbazel tests were disabled on Windows to save CI jobs slots, and
517524
# have bitrotted a bit. For now, just run a subset of what we're most
518525
# interested in.
@@ -522,6 +529,8 @@ tasks:
522529
platform: windows
523530
build_targets: ["//tests/integration:local_toolchains_test_bazel_self"]
524531
test_targets: ["//tests/integration:local_toolchains_test_bazel_self"]
532+
build_flags:
533+
- "--action_env=PATH"
525534

526535
integration_test_compile_pip_requirements_ubuntu:
527536
<<: *reusable_build_test_all

.bazelrc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ build --incompatible_default_to_explicit_init_py
2020
# Ensure ongoing compatibility with this flag.
2121
common --incompatible_disallow_struct_provider_syntax
2222

23+
common --incompatible_strict_action_env
24+
2325
# Windows makes use of runfiles for some rules
2426
build --enable_runfiles
2527

examples/bzlmod/.bazelrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,5 @@ test --test_output=errors --enable_runfiles
77

88
# Windows requires these for multi-python support:
99
build --enable_runfiles
10+
build --incompatible_strict_action_env
1011
common:bazel7.x --incompatible_python_disallow_native_rules

tests/integration/custom_commands_test.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
import logging
1615
import unittest
1716

1817
from tests.integration import runner

0 commit comments

Comments
 (0)