Skip to content

Commit b03beb1

Browse files
committed
fix the 'MINOR_MAPPING' import for the register_multi_toolchains
1 parent b2378ff commit b03beb1

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

python/private/python_register_multi_toolchains.bzl

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,11 @@
1515
"""This file contains repository rules and macros to support toolchain registration.
1616
"""
1717

18-
load("@pythons_hub//:versions.bzl", "MINOR_MAPPING")
18+
# NOTE @aignas 2024-10-07: we are not importing this from `@pythons_hub` because of this
19+
# leading to a backwards incompatible change - the `//python:repositories.bzl` is loading
20+
# from this file and it will cause a circular import loop and an error. If the users in
21+
# WORKSPACE world want to override the `minor_mapping`, they will have to pass an argument.
22+
load("//python:versions.bzl", "MINOR_MAPPING")
1923
load(":python_register_toolchains.bzl", "python_register_toolchains")
2024
load(":toolchains_repo.bzl", "multi_toolchain_aliases")
2125

0 commit comments

Comments
 (0)