Skip to content

Commit b92a67d

Browse files
committed
wip
1 parent c5ff77a commit b92a67d

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

python/private/pypi/whl_library.bzl

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,12 +335,16 @@ def _whl_library_impl(rctx):
335335
)
336336
entry_points[entry_point_without_py] = entry_point_script_name
337337

338+
# TODO @aignas 2025-02-24: move this to pkg_aliases layer to have this in
339+
# the analysis phase. This means that we need to get the target platform abi
340+
# from the python version/versions we are setting the package up for. We can
341+
# potentially get this from the python toolchain interpreter.
338342
package_deps = deps(
343+
# TODO @aignas 2025-02-24: get the data here by parsing the METADATA
344+
# file manually without involving python interpreter at all.
339345
name = metadata["name"],
340346
requires_dist = metadata["requires_dist"],
341347
# target the host platform if the target platform is not specified in the rule.
342-
# TODO @aignas 2025-02-24: move this to pkg_aliases layer to have this in the
343-
# analysis phase.
344348
platforms = target_platforms or [
345349
"{}_{}".format(metadata["abi"], host_platform(rctx)),
346350
],

0 commit comments

Comments
 (0)