Skip to content

Commit bbd4f44

Browse files
committed
default py_runtime.implementation_name to cpython
1 parent 9c3d303 commit bbd4f44

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ A brief description of the categories of changes:
2525
[x.x.x]: https://github.com/bazelbuild/rules_python/releases/tag/x.x.x
2626

2727
### Changed
28-
* Nothing yet
28+
* (toolchains) `py_runtime.implementation_name` now defaults to `cpython`
29+
(previously it defaulted to None).
2930

3031
### Fixed
3132
* (bzlmod) correctly wire the {attr}`pip.parse.extra_pip_args` all the

python/private/common/py_runtime_rule.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,7 @@ runtime. For a platform runtime this attribute must not be set.
226226
),
227227
"implementation_name": attr.string(
228228
doc = "The Python implementation name (`sys.implementation.name`)",
229+
default = "cpython",
229230
),
230231
"interpreter": attr.label(
231232
# We set `allow_files = True` to allow specifying executable

0 commit comments

Comments
 (0)