expand testing a bit

Author: rickeylev

tests/pypi/pep508/BUILD.bazel

@@ -15,6 +15,7 @@ requirement_test_suite(
     name = "requirement_tests",
 )
 
+# todo: move to subdir; it generates many test targets
 depspec_flag_test_suite(
     name = "depspec_flag_tests",
 )

tests/pypi/pep508/depspec_flag_tests.bzl

@@ -10,17 +10,26 @@ _tests = []
 
 def _test_expr(name):
     def impl(env, target):
-        attrs = target[TestingAspectInfo].attrs
-
         # todo: create FeatureFlagInfo subject
-        actual = target[config_common.FeatureFlagInfo].value
         env.expect.where(
-            expression = attrs.expression,
-        ).that_str(actual).equals("yes")
+            expression = target[TestingAspectInfo].attrs.expression,
+        ).that_str(
+            target[config_common.FeatureFlagInfo].value,
+        ).equals(
+            env.ctx.attr.expected,
+        )
 
     cases = {
         "python_version_gte": {
             "expression": "python_version >= '3.12.0'",
+            "expected": "yes",
+            "config_settings": {
+                PYTHON_VERSION: "3.12.0",
+            },
+        },
+        "python_full_version_lt_negative": {
+            "expression": "python_full_version < '3.8'",
+            "expected": "no",
             "config_settings": {
                 PYTHON_VERSION: "3.12.0",
             },
@@ -40,6 +49,12 @@ def _test_expr(name):
             impl = impl,
             target = test_name + "_subject",
             config_settings = case["config_settings"],
+            attr_values = {
+                "expected": case["expected"],
+            },
+            attrs = {
+                "expected": attr.string(),
+            },
         )
     native.test_suite(
         name = name,