Merge branch 'main' into fix/use_py_repo_utils_in_whl_library

Author: aignas

CHANGELOG.md

@@ -56,6 +56,10 @@ Unreleased changes template.
 * Bazel 6 support is dropped and Bazel 7.4.1 is the minimum supported
   version, per our Bazel support matrix. Earlier versions are not
   tested by CI, so functionality cannot be guaranteed.
+* ({bzl:obj}`pip.parse`) From now we will make fewer calls to indexes when
+  fetching the metadata from SimpleAPI. The calls will be done in parallel to
+  each index separately, so the extension evaluation time might slow down if
+  not using {bzl:obj}`pip.parse.experimental_index_url_overrides`.
 * ({bzl:obj}`pip.parse`) Only query SimpleAPI for packages that have
   sha values in the `requirements.txt` file.
 
@@ -80,6 +84,8 @@ Unreleased changes template.
 * (whl_library) Now the changes to the dependencies are correctly tracked when
   PyPI packages used in {bzl:obj}`whl_library` during the `repository_rule` phase
   change. Fixes [#2468](https://github.com/bazelbuild/rules_python/issues/2468).
++ (gazelle) Gazelle no longer ignores `setup.py` files by default. To restore
+  this behavior, apply the `# gazelle:python_ignore_files setup.py` directive.
 
 [pep-695]: https://peps.python.org/pep-0695/
 
@@ -100,6 +106,13 @@ Unreleased changes template.
     * 3.11.11
     * 3.12.8
     * 3.13.1
+* (rules) Attributes for type definition files (`.pyi` files) and type-checking
+  only dependencies added. See {obj}`py_library.pyi_srcs` and
+  `py_library.pyi_deps` (and the same named attributes for `py_binary` and
+  `py_test`).
+* (providers) {obj}`PyInfo` has new fields to aid static analysis tools:
+  {obj}`direct_original_sources`, {obj}`direct_pyi_files`,
+  {obj}`transitive_original_sources`, {obj}`transitive_pyi_files`.
 
 [20241206]: https://github.com/astral-sh/python-build-standalone/releases/tag/20241206
 

gazelle/python/testdata/dont_ignore_setup/BUILD.in

@@ -0,0 +1 @@
+# gazelle:python_generation_mode file

gazelle/python/testdata/dont_ignore_setup/BUILD.out

@@ -0,0 +1,9 @@
+load("@rules_python//python:defs.bzl", "py_library")
+
+# gazelle:python_generation_mode file
+
+py_library(
+    name = "setup",
+    srcs = ["setup.py"],
+    visibility = ["//:__subpackages__"],
+)

gazelle/python/testdata/dont_ignore_setup/README.md

@@ -0,0 +1,8 @@
+# Don't ignore setup.py files
+
+Make sure that files named `setup.py` are processed by Gazelle.
+
+It's believed that `setup.py` was originally ignored because it, when found
+in the repository root directory, is part of the `setuptools` build system
+and could cause some issues for Gazelle. However, files within source code can
+also be called `setup.py` and thus should be processed by Gazelle.

gazelle/python/testdata/dont_ignore_setup/WORKSPACE

@@ -0,0 +1,15 @@
+# Copyright 2024 The Bazel Authors. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+---

gazelle/python/testdata/dont_ignore_setup/setup.py

@@ -4,6 +4,9 @@ load("@rules_python//python:defs.bzl", "py_library")
 
 py_library(
     name = "python_ignore_files_directive",
-    srcs = ["__init__.py"],
+    srcs = [
+        "__init__.py",
+        "setup.py",
+    ],
     visibility = ["//:__subpackages__"],
 )

gazelle/python/testdata/dont_ignore_setup/test.yaml

@@ -126,7 +126,6 @@ const (
 // defaultIgnoreFiles is the list of default values used in the
 // python_ignore_files option.
 var defaultIgnoreFiles = map[string]struct{}{
-	"setup.py": {},
 }
 
 // Configs is an extension of map[string]*Config. It provides finding methods

gazelle/python/testdata/python_ignore_files_directive/BUILD.out

@@ -375,6 +375,35 @@ in the resulting output or not. Valid values are:
 * `omit_source`: Don't include the original py source.
 """,
         ),
+        "pyi_deps": attr.label_list(
+            doc = """
+Dependencies providing type definitions the library needs.
+
+These are dependencies that satisfy imports guarded by `typing.TYPE_CHECKING`.
+These are build-time only dependencies and not included as part of a runnable
+program (packaging rules may include them, however).
+
+:::{versionadded} VERSION_NEXT_FEATURE
+:::
+""",
+            providers = [
+                [PyInfo],
+                [CcInfo],
+            ] + _MaybeBuiltinPyInfo,
+        ),
+        "pyi_srcs": attr.label_list(
+            doc = """
+Type definition files for the library.
+
+These are typically `.pyi` files, but other file types for type-checker specific
+formats are allowed. These files are build-time only dependencies and not included
+as part of a runnable program (packaging rules may include them, however).
+
+:::{versionadded} VERSION_NEXT_FEATURE
+:::
+""",
+            allow_files = True,
+        ),
         # Required attribute, but details vary by rule.
         # Use create_srcs_attr to create one.
         "srcs": None,