Skip to content

Commit c56ac32

Browse files
committed
fix epoch parsing
1 parent cbbb345 commit c56ac32

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

python/private/version.bzl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,10 @@ def _parse_epoch(value):
596596
if not value:
597597
return 0
598598

599-
return int(value)
599+
if not value.endswith("!"):
600+
fail("epoch string segment needs to end with '!', got: {}".format(value))
601+
602+
return int(value[:-1])
600603

601604
def _parse_release(value):
602605
return tuple([int(d) for d in value.split(".")])

tests/pypi/pep508/evaluate_tests.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -338,6 +338,7 @@ def _test_ordering(env):
338338
"1.0.post456",
339339
"1.0.15",
340340
"1.1.dev1",
341+
"1!0.1",
341342
]
342343

343344
for lower, higher in zip(want[:-1], want[1:]):

0 commit comments

Comments
 (0)