Skip to content

Commit c6ffd3e

Browse files
committed
document the intention
1 parent 08d7f77 commit c6ffd3e

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

CHANGELOG.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,12 @@ END_UNRELEASED_TEMPLATE
7979
length errors due to too long environment variables.
8080
* (bootstrap) {obj}`--bootstrap_impl=script` now supports the `-S` interpreter
8181
setting.
82-
* (pypi) We now by default select the highest closest match wheel version if the user is
83-
specifying a particular version via the `whl_platform_tags` or if any version is matched via
84-
the `*` token, then we select the lowest available version.
85-
Fixes [#3250](https://github.com/bazel-contrib/rules_python/issues/3250).
82+
* (pypi) We now use the MVC algorithm to select the right wheel when there are multiple wheels for
83+
the target platform (e.g. `musllinux_1_1_x86_64` and `musllinux_1_2_x86_64`). If the user
84+
wants to set the minimum version for the selection algorithm, use the
85+
{attr}`pip.defaults.whl_platform_tags` attribute to configure that. If `musllinux_*_x86_64` is
86+
specified, we will chose the lowest available wheel version. Fixes
87+
[#3250](https://github.com/bazel-contrib/rules_python/issues/3250).
8688

8789
{#v0-0-0-added}
8890
### Added

python/private/pypi/extension.bzl

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -492,11 +492,12 @@ preference.
492492
Will always include `"any"` even if it is not specified.
493493
494494
The items in this list can contain a single `*` character that is equivalent to matching the
495-
latest available version component in the platform_tag. Note, if the wheel platform tag does not
496-
have a version component, e.g. `linux_x86_64` or `win_amd64`, then `*` will act as a regular
497-
character.
495+
lowest available version component in the platform_tag. Note, if the wheel platform tag does not
496+
have a version component, e.g. `linux_x86_64` or `win_amd64`, then `*` will act as a lower bound
497+
for the platform version, i.e. `musllinux_1_2_x86_64` means select a wheel that is built for
498+
`muslc` 1.2 or greater, i.e. prefer `musllinux_1_2_x86_64` over `musllinux_1_3_x86_64` over `musllinux_1_4_x86_64` and so on, but exclude `musllinux_1_1_x86_64` and lower.
498499
499-
We will always select the highest available `platform_tag` version that is compatible with the
500+
We will always select the lowest available `platform_tag` version that is compatible with the
500501
target platform.
501502
502503
:::{note}

0 commit comments

Comments
 (0)