linter cleanup

Author: rickeylev

python/private/py_executable_bazel.bzl

@@ -347,6 +347,17 @@ def _create_zip_main(ctx, *, stage2_bootstrap, runtime_details, venv):
 # Return a relative path from one path to another, where both paths are each
 # relative paths from a common root.
 def relative_path(from_, to):
+    """Compute a relative path from one path to another.
+
+    Args:
+        from_: {type}`str` the starting directory. Note that it should be
+            a directory because relative-symlinks are relative to the
+            directory the symlink resides in.
+        to: {type}`str` the path that `from_` wants to point to
+
+    Returns:
+        {type}`str` a relative path
+    """
     from_parts = from_.split("/")
     to_parts = to.split("/")
 

tests/bootstrap_impls/BUILD.bazel

@@ -14,6 +14,7 @@
 
 load("//python/private:util.bzl", "IS_BAZEL_7_OR_HIGHER")  # buildifier: disable=bzl-visibility
 load("//tests/support:sh_py_run_test.bzl", "py_reconfig_test", "sh_py_run_test")
+load(":venv_relative_path_tests.bzl", "relative_path_test_suite")
 
 _SUPPORTS_BOOTSTRAP_SCRIPT = select({
     "@platforms//os:windows": ["@platforms//:incompatible"],
@@ -88,6 +89,4 @@ sh_py_run_test(
     target_compatible_with = _SUPPORTS_BOOTSTRAP_SCRIPT,
 )
 
-load(":venv_relative_path_tests.bzl", "relative_path_test_suite")
-
-relative_path_test_suite("relative_path_test")
+relative_path_test_suite(name = "relative_path_test")

tests/bootstrap_impls/a/b/c/BUILD.bazel

@@ -1,6 +1,5 @@
-load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
 load("//python/private:util.bzl", "IS_BAZEL_7_OR_HIGHER")  # buildifier: disable=bzl-visibility
-load("//tests/support:sh_py_run_test.bzl", "py_reconfig_test", "sh_py_run_test")
+load("//tests/support:sh_py_run_test.bzl", "py_reconfig_test")
 
 _SUPPORTS_BOOTSTRAP_SCRIPT = select({
     "@platforms//os:windows": ["@platforms//:incompatible"],

tests/bootstrap_impls/a/b/c/nested_dir_test.py

@@ -15,8 +15,10 @@
 
 import unittest
 
+
 class RunsTest(unittest.TestCase):
     def test_runs(self):
         pass
 
+
 unittest.main()

tests/bootstrap_impls/venv_relative_path_tests.bzl

@@ -14,7 +14,7 @@
 
 "Unit tests for yaml.bzl"
 
-load("@bazel_skylib//lib:unittest.bzl", "analysistest", "asserts", "unittest")
+load("@bazel_skylib//lib:unittest.bzl", "asserts", "unittest")
 load("//python/private:py_executable_bazel.bzl", "relative_path")  # buildifier: disable=bzl-visibility
 
 def _relative_path_test_impl(ctx):
@@ -117,5 +117,5 @@ relative_path_test = unittest.make(
     attrs = {},
 )
 
-def relative_path_test_suite(name):
+def relative_path_test_suite(*, name):
     unittest.suite(name, relative_path_test)