Skip to content

Commit d57994c

Browse files
committed
chore!(pip.parse): remove parse_all_requirements_files attribute
1 parent c8ccd22 commit d57994c

File tree

6 files changed

+200
-437
lines changed

6 files changed

+200
-437
lines changed

CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,11 @@ Unreleased changes template.
5252

5353
{#v0-0-0-changed}
5454
### Changed
55+
**Breaking**:
56+
* (bzlmod) `pip.parse.parse_all_requirements_files` attribute has been removed.
57+
See notes in the previous versions about what to do.
58+
59+
Other changes:
5560
* Nothing yet.
5661

5762
{#v0-0-0-fixed}
@@ -150,7 +155,7 @@ Unreleased changes template.
150155
* (bzlmod) The extension evaluation has been adjusted to always generate the
151156
same lock file irrespective if `experimental_index_url` is set by any module
152157
or not. To opt into this behavior, set
153-
{bzl:obj}`pip.parse.parse_all_requirements_files`, which will become the
158+
`pip.parse.parse_all_requirements_files`, which will become the
154159
default in future releases leading up to `1.0.0`. Fixes
155160
[#2268](https://github.com/bazelbuild/rules_python/issues/2268). A known
156161
issue is that it may break `bazel query` and in these use cases it is

MODULE.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ register_toolchains("@pythons_hub//:all")
5454
#####################
5555
# Install twine for our own runfiles wheel publishing and allow bzlmod users to use it.
5656

57-
pip = use_extension("//python/private/pypi:pip.bzl", "pip_internal")
57+
pip = use_extension("//python/extensions:pip.bzl", "pip")
5858
pip.parse(
5959
# NOTE @aignas 2024-10-26: We have an integration test that depends on us
6060
# being able to build sdists for this hub, so explicitly set this to False.

examples/bzlmod/MODULE.bazel

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,9 +231,6 @@ pip.parse(
231231
"host",
232232
],
233233
hub_name = "pip",
234-
# Parse all requirements files for the same lock file on all OSes, this will
235-
# become the default with 1.0 release
236-
parse_all_requirements_files = True,
237234
python_version = "3.10",
238235
# The requirements files for each platform that we want to support.
239236
requirements_by_platform = {

0 commit comments

Comments
 (0)