Skip to content

Commit db8fa24

Browse files
committed
update docs
1 parent 0cba8d5 commit db8fa24

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

MODULE.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ pip = use_extension("//python/extensions:pip.bzl", "pip")
7070
config_settings = [
7171
"@platforms//cpu:{}".format(cpu),
7272
"@platforms//os:linux",
73-
"//python/config_settings:_is_py_linux_libc_glibc",
7473
],
7574
env = {"platform_version": "0"},
7675
os_name = "linux",

python/private/pypi/extension.bzl

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -905,14 +905,21 @@ A list of `platform_tag` matchers so that we can select the best wheel based on
905905
preference.
906906
Will always include `"any"` even if it is not specified.
907907
908-
The items in this list can contain a single `*` character that is equivalent to `.*` regex match. This is only applicable in place of version specifiers in the platform tags.
908+
The items in this list can contain a single `*` character that is equivalent to matching the
909+
latest available version component in the platform_tag. Note, if the wheel platform tag does not
910+
have a version component, e.g. `linux_x86_64` or `win_amd64`, then `*` will act as a regular
911+
character.
909912
910-
We will always select the highest available platform_tag version that exists.
911-
912-
TODO: refine.
913+
We will always select the highest available `platform_tag` version that is compatible with the
914+
target platform.
913915
914916
:::{note}
915-
We select a single wheel and the last match will take precedence.
917+
We select a single wheel and the last match will take precedence, if the platform_tag that we
918+
match has a version component (e.g. `android_x_arch`, then the version `x` will be used in the
919+
matching algorithm).
920+
921+
If the matcher you provide has `*`, then we will match a wheel with the highest available target platform, i.e. if `musllinux_1_1_arch` and `musllinux_1_2_arch` are both present, then we will select `musllinux_1_2_arch`.
922+
Otherwise we will select the highest available version that is equal or lower to the specifier, i.e. if `manylinux_2_12` and `manylinux_2_17` wheels are present and the matcher is `manylinux_2_15`, then we will match `manylinux_2_12` but not `manylinux_2_17`.
916923
:::
917924
918925
:::{note}

0 commit comments

Comments
 (0)