Skip to content

Commit db949b2

Browse files
committed
fix tests
1 parent a98f654 commit db949b2

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

python/private/py_wheel_normalize_pep440.bzl

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -587,17 +587,18 @@ def _version_gt(left, right):
587587
left_release = _pad_zeros(left.release, release_len)
588588
right_release = _pad_zeros(right.release, release_len)
589589

590-
# It cannot be pre and post release at the same time, so the following should be fine
591-
if not left.post and right.post:
592-
return False
593-
594590
if left_release > right_release:
595591
return True
596592
elif left_release < right_release:
597593
return False
598594

595+
# the release is equal, check for post version
599596
if right.post:
600-
if left.post > right.post:
597+
if not left.post:
598+
# PEP440: The exclusive ordered comparison >V MUST NOT allow a post-release of the
599+
# given version unless V itself is a post release.
600+
return False
601+
elif left.post > right.post:
601602
return True
602603
elif left.post < right.post:
603604
return False

tests/pypi/pep508/evaluate_tests.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -279,10 +279,10 @@ _MISC_EXPRESSIONS = [
279279
_expr_case('python_version > "1.7"', True, {"python_version": "1.7.1"}),
280280
_expr_case('python_version > "1.7"', False, {"python_version": "1.7.0.post0"}),
281281
_expr_case('python_version > "1.7"', True, {"python_version": "1.7.1"}),
282-
_expr_case('python_version > "1.7.post2"', False, {"python_version": "1.7.0"}),
282+
_expr_case('python_version > "1.7.post2"', True, {"python_version": "1.7.1"}),
283283
_expr_case('python_version > "1.7.post2"', True, {"python_version": "1.7.post3"}),
284-
_expr_case('python_version > "1.7.post2"', False, {"python_version": "1.7.1"}),
285-
_expr_case('python_version > "1.7+local"', True, {"python_version": "1.7.1"}),
284+
_expr_case('python_version > "1.7.post2"', False, {"python_version": "1.7.0"}),
285+
_expr_case('python_version > "1.7.1+local"', False, {"python_version": "1.7.1"}),
286286
# TODO @aignas 2025-05-05: add tests for pre-releases
287287
]
288288

0 commit comments

Comments
 (0)