Skip to content

Commit df960b1

Browse files
Add tickets and PR comments
1 parent 708edb5 commit df960b1

File tree

3 files changed

+24
-10
lines changed

3 files changed

+24
-10
lines changed

README.md

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,27 @@ Bazel rules to transitively fetch and install Python dependencies from a require
44

55
## Features
66

7-
* Transitive Dependency Resolution
8-
* Support for purelibs
7+
The rules address most of the top packaging issues in rules_python. This means the rules support common packages such
8+
as tensorflow and google.cloud natively.
9+
10+
* Transitive dependency resolution.
11+
* https://github.com/bazelbuild/rules_python/issues/35
12+
* https://github.com/bazelbuild/rules_python/issues/102
13+
* Minimal runtime dependencies.
14+
* https://github.com/bazelbuild/rules_python/issues/184
15+
* Support for purelibs.
16+
* https://github.com/bazelbuild/rules_python/issues/71
917
* Support for namespace packages
10-
* Minimal runtime dependencies
18+
* https://github.com/bazelbuild/rules_python/issues/14
19+
* https://github.com/bazelbuild/rules_python/issues/55
20+
* https://github.com/bazelbuild/rules_python/issues/65
21+
* https://github.com/bazelbuild/rules_python/issues/93
22+
* https://github.com/bazelbuild/rules_python/issues/189
23+
* Fetches pip packages only for building Python targets
24+
* https://github.com/bazelbuild/rules_python/issues/96
25+
* Reproducible builds
26+
* https://github.com/bazelbuild/rules_python/issues/154
27+
* https://github.com/bazelbuild/rules_python/issues/176
1128

1229
## Usage
1330

@@ -57,7 +74,7 @@ Note that above you do not need to add transitively required packages to `deps =
5774
#### Setup `requirements.txt`
5875

5976
While `rules_python_external` **does not** require a _transitively-closed_ `requirements.txt` file, it is recommended.
60-
But if you want to just have top-level packages listed, that works.
77+
But if you want to just have top-level packages listed, that also will work.
6178

6279
Transitively-closed requirements specs are very tedious to produce and maintain manually. To automate the process we
6380
recommend [`pip-compile` from `jazzband/pip-tools`](https://github.com/jazzband/pip-tools#example-usage-for-pip-compile).
@@ -70,8 +87,6 @@ botocore~=1.12.247
7087
click~=7.0
7188
```
7289

73-
These above are the third-party packages you can directly import.
74-
7590
`pip-compile` 'compiles' it so you get a transitively-closed `requirements.txt` like this, which should be passed to
7691
`pip_install` below:
7792

extract_wheels/__init__.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,8 @@ def configure_reproducible_wheels() -> None:
4343
def main() -> None:
4444
"""Main program.
4545
46-
Returns:
47-
Zero on successful program termination, non-zero otherwise.
48-
"""
46+
Exits zero on successful program termination, non-zero otherwise.
47+
"""
4948

5049
configure_reproducible_wheels()
5150

tools/typing/mypy.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[mypy]
2-
# The should be the oldest supported release of Python
2+
# This should be the oldest supported release of Python
33
# https://devguide.python.org/#status-of-python-branches
44
python_version = 3.5
55

0 commit comments

Comments
 (0)