Skip to content

Commit e1ff659

Browse files
authored
Apply suggestions from code review
1 parent 42dac20 commit e1ff659

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ END_UNRELEASED_TEMPLATE
7676
for a target). If they don't match, dependencies won't be importable. (Such a
7777
misconfiguration was unlikely to work to begin with; this is called out as an
7878
FYI).
79-
* (rules) {obj}`--bootstrap_impl=script` is the default for non-Windows for bazel 8 and above.
79+
* (rules) {obj}`--bootstrap_impl=script` is the default for non-Windows for Bazel 8 and above.
8080

8181
{#v0-0-0-fixed}
8282
### Fixed

docs/api/rules_python/python/config_settings/index.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -245,9 +245,11 @@ Values:
245245
::::{bzl:flag} bootstrap_impl
246246
Determine how programs implement their startup process.
247247

248-
The default for this depends on the platform:
248+
The default for this depends on the platform and environment:
249249
* Windows: `system_python` (**always** used)
250-
* Other: `script`
250+
* Non-Windows with Bazel 8 or higher: `script`
251+
* Other: `system_python`
252+
251253

252254
Values:
253255
* `system_python`: Use a bootstrap that requires a system Python available
@@ -274,8 +276,7 @@ instead.
274276
:::
275277

276278
:::{versionchanged} VERSION_NEXT_FEATURE
277-
* The default for non-Windows changed from `system_python` to `script`.
278-
* On Windows, the value is forced to `system_python`.
279+
* The default changed from `system_python` to `script` for non-Windows with Bazel 8 or higher.
279280
:::
280281

281282
::::

python/private/util.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ def define_bazel_6_provider(doc, fields, **kwargs):
9999
return provider("Stub, not used", fields = []), None
100100
return provider(doc = doc, fields = fields, **kwargs)
101101

102-
# Only bazel 8 can distinguish symlinks within the file depsets.
102+
# `config.none` was introduced in Bazel 8
103103
IS_BAZEL_8_OR_HIGHER = hasattr(config, "none")
104104

105105
IS_BAZEL_7_4_OR_HIGHER = hasattr(native, "legacy_globals")

0 commit comments

Comments
 (0)