skip test on windows

Author: rickeylev

tests/bootstrap_impls/bin_calls_bin/BUILD.bazel

@@ -1,6 +1,6 @@
 load("@rules_shell//shell:sh_test.bzl", "sh_test")
 load("//tests/support:py_reconfig.bzl", "py_reconfig_binary")
-load("//tests/support:support.bzl", "SUPPORTS_BOOTSTRAP_SCRIPT")
+load("//tests/support:support.bzl", "NOT_WINDOWS", "SUPPORTS_BOOTSTRAP_SCRIPT")
 
 # =====
 # bootstrap_impl=system_python testing
@@ -39,6 +39,10 @@ sh_test(
         "verify.sh",
         ":outer_calls_inner_system_python",
     ],
+    # The way verify_system_python.sh loads verify.sh doesn't work
+    # with Windows for some annoying reason. Just skip windows for now;
+    # the logic being test isn't OS-specific, so this should be fine.
+    target_compatible_with = NOT_WINDOWS,
 )
 
 # =====

tests/bootstrap_impls/bin_calls_bin/verify_script_python.sh

@@ -1,17 +1,5 @@
 #!/bin/bash
 set -euo pipefail
 
-# rules_python_get_runfiles_path is a helper to correctly look up runfiles.
-# It is needed because on Windows, the path to a runfile can be absolute,
-# which is not something that bash can handle. So we use cygpath to fix it up.
-rules_python_get_runfiles_path() {
-    local path="$1"
-    if [[ -f /bin/cygpath ]]; then
-        cygpath -u "${path}"
-    else
-        echo "${path}"
-    fi
-}
-
-source "$(rules_python_get_runfiles_path "$(dirname "$0")/verify.sh")"
-verify_output "$(rules_python_get_runfiles_path "$(dirname "$0")/outer_calls_inner_script_python.out")"
+source "$(dirname "$0")/verify.sh"
+verify_output "$(dirname "$0")/outer_calls_inner_script_python.out"

tests/bootstrap_impls/bin_calls_bin/verify_system_python.sh

@@ -1,17 +1,5 @@
 #!/bin/bash
 set -euo pipefail
 
-# rules_python_get_runfiles_path is a helper to correctly look up runfiles.
-# It is needed because on Windows, the path to a runfile can be absolute,
-# which is not something that bash can handle. So we use cygpath to fix it up.
-rules_python_get_runfiles_path() {
-    local path="$1"
-    if [[ -f /bin/cygpath ]]; then
-        cygpath -u "${path}"
-    else
-        echo "${path}"
-    fi
-}
-
-source "$(rules_python_get_runfiles_path "$(dirname "$0")/verify.sh")"
-verify_output "$(rules_python_get_runfiles_path "$(dirname "$0")/outer_calls_inner_system_python.out")"
+source "$(dirname "$0")/verify.sh"
+verify_output "$(dirname "$0")/outer_calls_inner_system_python.out"

tests/support/support.bzl

@@ -54,3 +54,8 @@ SUPPORTS_BZLMOD_UNIXY = select({
     "@platforms//os:windows": ["@platforms//:incompatible"],
     "//conditions:default": [],
 }) if BZLMOD_ENABLED else ["@platforms//:incompatible"]
+
+NOT_WINDOWS = select({
+    "@platforms//os:windows": ["@platforms//:incompatible"],
+    "//conditions:default": [],
+})