Skip to content

Commit e99bc2d

Browse files
committed
feat: default to bootstrap script for non-windows
1 parent 4ccf5b2 commit e99bc2d

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ END_UNRELEASED_TEMPLATE
5555
{#v0-0-0-changed}
5656
### Changed
5757

58+
* (rules) {obj}`--bootstrap_impl=script` is the default for non-Windows.
5859
* (rules) On Windows, {obj}`--bootstrap_impl=system_python` is forced. This
5960
allows setting `--bootstrap_impl=script` in bazelrc for mixed-platform
6061
environments.

docs/api/rules_python/python/config_settings/index.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,10 @@ Values:
233233
::::{bzl:flag} bootstrap_impl
234234
Determine how programs implement their startup process.
235235

236+
The default for this depends on the platform:
237+
* Windows: `system_python` (**always** used)
238+
* Other: `script`
239+
236240
Values:
237241
* `system_python`: Use a bootstrap that requires a system Python available
238242
in order to start programs. This requires
@@ -257,6 +261,11 @@ instead.
257261
:::{versionadded} 0.33.0
258262
:::
259263

264+
:::{versionchanged} VERSION_NEXT_FEATURE
265+
* The default for non-Windows changed from `system_python` to `script`.
266+
* On Windows, the value is forced to `system_python`.
267+
:::
268+
260269
::::
261270

262271
::::{bzl:flag} current_config

python/config_settings/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ string_flag(
9090

9191
rp_string_flag(
9292
name = "bootstrap_impl",
93-
build_setting_default = BootstrapImplFlag.SYSTEM_PYTHON,
93+
build_setting_default = BootstrapImplFlag.SCRIPT,
9494
override = select({
9595
# Windows doesn't yet support bootstrap=script, so force disable it
9696
":_is_windows": BootstrapImplFlag.SYSTEM_PYTHON,

0 commit comments

Comments
 (0)