Skip to content

Commit eae0985

Browse files
sputtdougthor42
andauthored
fix(gazelle): Fix the requirements arg to the gazelle python manifest generator. (#2533)
Fix args passed into the gazelle manifest file generator if the requirements file is not a source file. --------- Co-authored-by: Douglas Thor <[email protected]>
1 parent 38135f7 commit eae0985

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# rules_python Changelog
55

66
This is a human-friendly changelog in a keepachangelog.com style format.
7-
Because this changelog is for end-user consumption of meaningful changes,only
7+
Because this changelog is for end-user consumption of meaningful changes, only
88
a summary of a release's changes is described. This means every commit is not
99
necessarily mentioned, and internal refactors or code cleanups are omitted
1010
unless they're particularly notable.
@@ -56,7 +56,7 @@ Unreleased changes template.
5656

5757
{#v0-0-0-fixed}
5858
### Fixed
59-
* Nothing fixed.
59+
* (gazelle) Providing multiple input requirements files to `gazelle_python_manifest` now works correctly.
6060

6161
{#v0-0-0-added}
6262
### Added

gazelle/manifest/defs.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def gazelle_python_manifest(
7979

8080
update_args = [
8181
"--manifest-generator-hash=$(execpath {})".format(manifest_generator_hash),
82-
"--requirements=$(rootpath {})".format(requirements) if requirements else "--requirements=",
82+
"--requirements=$(execpath {})".format(requirements) if requirements else "--requirements=",
8383
"--pip-repository-name={}".format(pip_repository_name),
8484
"--modules-mapping=$(execpath {})".format(modules_mapping),
8585
"--output=$(execpath {})".format(generated_manifest),

0 commit comments

Comments
 (0)