Skip to content

Commit eb2de67

Browse files
committed
clarify the doc
1 parent bb838c0 commit eb2de67

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

python/private/pypi/extension.bzl

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,15 @@ def _platforms(*, python_version, minor_mapping, config):
8080
for platform, values in config.platforms.items():
8181
# TODO @aignas 2025-07-07: this is probably doing the parsing of the version too
8282
# many times.
83-
pytag = python_tag(values.env["implementation_name"], python_version.string)
83+
key = "{}{}{}.{}_{}".format(
84+
python_tag(values.env["implementation_name"]),
85+
python_version.release[0],
86+
python_version.release[1],
87+
python_version.release[2],
88+
platform,
89+
)
8490

85-
platforms["{}.{}_{}".format(pytag, python_version.release[2], platform)] = struct(
91+
platforms[key] = struct(
8692
env = env(
8793
env = values.env,
8894
os = values.os_name,
@@ -795,6 +801,7 @@ _default_attrs = {
795801
"arch_name": attr.string(
796802
doc = """\
797803
The CPU architecture name to be used.
804+
You can use any cpu name from the `@platforms//cpu:` package.
798805
799806
:::{note}
800807
Either this or {attr}`env` `platform_machine` key should be specified.
@@ -836,6 +843,7 @@ This is only used if the {envvar}`RULES_PYTHON_ENABLE_PIPSTAR` is enabled.
836843
"os_name": attr.string(
837844
doc = """\
838845
The OS name to be used.
846+
You can use any OS name from the `@platforms//os:` package.
839847
840848
:::{note}
841849
Either this or the appropriate `env` keys should be specified.

0 commit comments

Comments
 (0)