avoid circular load deps

Author: aignas

CHANGELOG.md

@@ -60,6 +60,8 @@ END_UNRELEASED_TEMPLATE
 * (gazelle) Types for exposed members of `python.ParserOutput` are now all public.
 * (toolchains): Using [20250612] release of the `python-build-standalone` release.
 * (toolchains): Bumped `3.13` to use `3.13.5` version.
+* (toolchains): Moved the `print_toolchains_checksums` to
+  `//python/private:print_toolchains_checksums.bzl`.
 
 [20250612]: https://github.com/astral-sh/python-build-standalone/releases/tag/20250612
 

python/BUILD.bazel

@@ -247,10 +247,7 @@ bzl_library(
     name = "versions_bzl",
     srcs = ["versions.bzl"],
     visibility = ["//:__subpackages__"],
-    deps = [
-        "//python/private:platform_info_bzl",
-        "//python/private:text_util_bzl",
-    ],
+    deps = ["//python/private:platform_info_bzl"],
 )
 
 # NOTE: Remember to add bzl_library targets to //tests:bzl_libraries

python/private/BUILD.bazel

@@ -16,7 +16,7 @@ load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 load("@bazel_skylib//rules:common_settings.bzl", "bool_setting")
 load("//python:py_binary.bzl", "py_binary")
 load("//python:py_library.bzl", "py_library")
-load("//python:versions.bzl", "print_toolchains_checksums")
+load("print_toolchain_checksums.bzl", "print_toolchains_checksums")
 load(":py_exec_tools_toolchain.bzl", "current_interpreter_executable")
 load(":sentinel.bzl", "sentinel")
 load(":stamp.bzl", "stamp_build_setting")

python/private/print_toolchain_checksums.bzl

@@ -0,0 +1,87 @@
+"""Print the toolchain versions
+"""
+
+load("//python:versions.bzl", "TOOL_VERSIONS", "get_release_info")
+load("//python/private:text_util.bzl", "render")
+
+def print_toolchains_checksums(name):
+    """A macro to print checksums for a particular Python interpreter version.
+
+    Args:
+        name: {type}`str`: the name of the runnable target.
+    """
+    all_commands = []
+    by_version = {}
+
+    for python_version, metadata in TOOL_VERSIONS.items():
+        by_version[python_version] = _commands_for_version(
+            python_version = python_version,
+            metadata = metadata,
+        )
+        all_commands.append(by_version[python_version])
+
+    template = """\
+cat > "$@" <<'EOF'
+#!/bin/bash
+
+set -o errexit -o nounset -o pipefail
+
+echo "Fetching hashes..."
+
+{commands}
+EOF
+    """
+
+    native.genrule(
+        name = name,
+        srcs = [],
+        outs = ["print_toolchains_checksums.sh"],
+        cmd = select({
+            "//python/config_settings:is_python_{}".format(version): template.format(
+                commands = commands,
+            )
+            for version, commands in by_version.items()
+        } | {
+            "//conditions:default": template.format(commands = "\n".join(all_commands)),
+        }),
+        executable = True,
+    )
+
+def _commands_for_version(*, python_version, metadata):
+    lines = []
+    lines += [
+        "cat <<EOB",  # end of block
+        "    \"{python_version}\": {{".format(python_version = python_version),
+        "        \"url\": \"{url}\",".format(url = metadata["url"]),
+        "        \"sha256\": {",
+    ]
+
+    for platform in metadata["sha256"].keys():
+        for release_url in get_release_info(platform, python_version)[1]:
+            # Do lines one by one so that the progress is seen better and use cat for ease of quotation
+            lines += [
+                "EOB",
+                "cat <<EOB",
+                "            \"{platform}\": \"$$({get_sha256})\",".format(
+                    platform = platform,
+                    get_sha256 = "curl --location --fail {release_url_sha256} 2>/dev/null || curl --location --fail {release_url} 2>/dev/null | shasum -a 256 | awk '{{ print $$1 }}'".format(
+                        release_url = release_url,
+                        release_url_sha256 = release_url + ".sha256",
+                    ),
+                ),
+            ]
+
+    prefix = metadata["strip_prefix"]
+    prefix = render.indent(
+        render.dict(prefix) if type(prefix) == type({}) else repr(prefix),
+        indent = " " * 8,
+    ).lstrip()
+
+    lines += [
+        "        },",
+        "        \"strip_prefix\": {strip_prefix},".format(strip_prefix = prefix),
+        "    },",
+        "EOB",
+    ]
+
+    return "\n".join(lines)

python/versions.bzl

@@ -16,7 +16,6 @@
 """
 
 load("//python/private:platform_info.bzl", "platform_info")
-load("//python/private:text_util.bzl", "render")
 
 # Values present in the @platforms//os package
 MACOS_NAME = "osx"
@@ -441,88 +440,6 @@ def get_release_info(platform, python_version, base_url = DEFAULT_RELEASE_BASE_U
 
     return (release_filename, rendered_urls, strip_prefix, patches, patch_strip)
 
-def print_toolchains_checksums(name):
-    """A macro to print checksums for a particular Python interpreter version.
-
-    Args:
-        name: {type}`str`: the name of the runnable target.
-    """
-    all_commands = []
-    by_version = {}
-
-    for python_version, metadata in TOOL_VERSIONS.items():
-        by_version[python_version] = _commands_for_version(
-            python_version = python_version,
-            metadata = metadata,
-        )
-        all_commands.append(by_version[python_version])
-
-    template = """\
-cat > "$@" <<'EOF'
-#!/bin/bash
-
-set -o errexit -o nounset -o pipefail
-
-echo "Fetching hashes..."
-
-{commands}
-EOF
-    """
-
-    native.genrule(
-        name = name,
-        srcs = [],
-        outs = ["print_toolchains_checksums.sh"],
-        cmd = select({
-            "//python/config_settings:is_python_{}".format(version): template.format(
-                commands = commands,
-            )
-            for version, commands in by_version.items()
-        } | {
-            "//conditions:default": template.format(commands = "\n".join(all_commands)),
-        }),
-        executable = True,
-    )
-
-def _commands_for_version(*, python_version, metadata):
-    lines = []
-    lines += [
-        "cat <<EOB",  # end of block
-        "    \"{python_version}\": {{".format(python_version = python_version),
-        "        \"url\": \"{url}\",".format(url = metadata["url"]),
-        "        \"sha256\": {",
-    ]
-
-    for platform in metadata["sha256"].keys():
-        for release_url in get_release_info(platform, python_version)[1]:
-            # Do lines one by one so that the progress is seen better and use cat for ease of quotation
-            lines += [
-                "EOB",
-                "cat <<EOB",
-                "            \"{platform}\": \"$$({get_sha256})\",".format(
-                    platform = platform,
-                    get_sha256 = "curl --location --fail {release_url_sha256} 2>/dev/null || curl --location --fail {release_url} 2>/dev/null | shasum -a 256 | awk '{{ print $$1 }}'".format(
-                        release_url = release_url,
-                        release_url_sha256 = release_url + ".sha256",
-                    ),
-                ),
-            ]
-
-    prefix = metadata["strip_prefix"]
-    prefix = render.indent(
-        render.dict(prefix) if type(prefix) == type({}) else repr(prefix),
-        indent = " " * 8,
-    ).lstrip()
-
-    lines += [
-        "        },",
-        "        \"strip_prefix\": {strip_prefix},".format(strip_prefix = prefix),
-        "    },",
-        "EOB",
-    ]
-
-    return "\n".join(lines)
-
 def gen_python_config_settings(name = ""):
     for platform in PLATFORMS.keys():
         native.config_setting(