Skip to content

Commit f1e9eee

Browse files
committed
fixup tests
1 parent d0ea5fe commit f1e9eee

File tree

1 file changed

+21
-18
lines changed

1 file changed

+21
-18
lines changed

tests/pypi/parse_requirements/parse_requirements_tests.bzl

Lines changed: 21 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,10 @@
1515
""
1616

1717
load("@rules_testing//lib:test_suite.bzl", "test_suite")
18-
load("//python/private/pypi:parse_requirements.bzl", "parse_requirements", "select_requirement") # buildifier: disable=bzl-visibility
19-
load("//python/private/pypi:pep508_env.bzl", pep508_env = "env") # buildifier: disable=bzl-visibility
18+
load("//python/private:repo_utils.bzl", "REPO_DEBUG_ENV_VAR", "REPO_VERBOSITY_ENV_VAR", "repo_utils") # buildifier: disable=bzl-visibility
2019
load("//python/private/pypi:evaluate_markers.bzl", "evaluate_markers") # buildifier: disable=bzl-visibility
20+
load("//python/private/pypi:parse_requirements.bzl", "select_requirement", _parse_requirements = "parse_requirements") # buildifier: disable=bzl-visibility
21+
load("//python/private/pypi:pep508_env.bzl", pep508_env = "env") # buildifier: disable=bzl-visibility
2122

2223
def _mock_ctx():
2324
testdata = {
@@ -104,9 +105,22 @@ bar==0.0.1 --hash=sha256:deadb00f
104105

105106
_tests = []
106107

108+
def parse_requirements(debug = False, **kwargs):
109+
return _parse_requirements(
110+
ctx = _mock_ctx(),
111+
logger = repo_utils.logger(struct(
112+
os = struct(
113+
environ = {
114+
REPO_DEBUG_ENV_VAR: "1",
115+
REPO_VERBOSITY_ENV_VAR: "TRACE" if debug else "INFO",
116+
},
117+
),
118+
), "unit-test"),
119+
**kwargs
120+
)
121+
107122
def _test_simple(env):
108123
got = parse_requirements(
109-
ctx = _mock_ctx(),
110124
requirements_by_platform = {
111125
"requirements_lock": ["linux_x86_64", "windows_x86_64"],
112126
},
@@ -139,7 +153,6 @@ _tests.append(_test_simple)
139153
def _test_direct_urls_integration(env):
140154
"""Check that we are using the filename from index_sources."""
141155
got = parse_requirements(
142-
ctx = _mock_ctx(),
143156
requirements_by_platform = {
144157
"requirements_direct": ["linux_x86_64"],
145158
"requirements_direct_sdist": ["osx_x86_64"],
@@ -179,7 +192,6 @@ _tests.append(_test_direct_urls_integration)
179192

180193
def _test_extra_pip_args(env):
181194
got = parse_requirements(
182-
ctx = _mock_ctx(),
183195
requirements_by_platform = {
184196
"requirements_extra_args": ["linux_x86_64"],
185197
},
@@ -211,7 +223,6 @@ _tests.append(_test_extra_pip_args)
211223

212224
def _test_dupe_requirements(env):
213225
got = parse_requirements(
214-
ctx = _mock_ctx(),
215226
requirements_by_platform = {
216227
"requirements_lock_dupe": ["linux_x86_64"],
217228
},
@@ -240,7 +251,6 @@ _tests.append(_test_dupe_requirements)
240251

241252
def _test_multi_os(env):
242253
got = parse_requirements(
243-
ctx = _mock_ctx(),
244254
requirements_by_platform = {
245255
"requirements_linux": ["linux_x86_64"],
246256
"requirements_windows": ["windows_x86_64"],
@@ -304,7 +314,6 @@ _tests.append(_test_multi_os)
304314

305315
def _test_multi_os_legacy(env):
306316
got = parse_requirements(
307-
ctx = _mock_ctx(),
308317
requirements_by_platform = {
309318
"requirements_linux_download_only": ["cp39_linux_x86_64"],
310319
"requirements_osx_download_only": ["cp39_osx_aarch64"],
@@ -385,7 +394,6 @@ def _test_env_marker_resolution(env):
385394
return ret
386395

387396
got = parse_requirements(
388-
ctx = _mock_ctx(),
389397
requirements_by_platform = {
390398
"requirements_marker": ["cp311_linux_super_exotic", "cp311_windows_x86_64"],
391399
},
@@ -432,7 +440,6 @@ _tests.append(_test_env_marker_resolution)
432440

433441
def _test_different_package_version(env):
434442
got = parse_requirements(
435-
ctx = _mock_ctx(),
436443
requirements_by_platform = {
437444
"requirements_different_package_version": ["linux_x86_64"],
438445
},
@@ -471,7 +478,6 @@ _tests.append(_test_different_package_version)
471478

472479
def _test_optional_hash(env):
473480
got = parse_requirements(
474-
ctx = _mock_ctx(),
475481
requirements_by_platform = {
476482
"requirements_optional_hash": ["linux_x86_64"],
477483
},
@@ -510,7 +516,6 @@ _tests.append(_test_optional_hash)
510516

511517
def _test_git_sources(env):
512518
got = parse_requirements(
513-
ctx = _mock_ctx(),
514519
requirements_by_platform = {
515520
"requirements_git": ["linux_x86_64"],
516521
},
@@ -539,7 +544,6 @@ _tests.append(_test_git_sources)
539544

540545
def _test_overlapping_shas_with_index_results(env):
541546
got = parse_requirements(
542-
ctx = _mock_ctx(),
543547
requirements_by_platform = {
544548
"requirements_linux": ["cp39_linux_x86_64"],
545549
"requirements_osx": ["cp39_osx_x86_64"],
@@ -626,7 +630,6 @@ _tests.append(_test_overlapping_shas_with_index_results)
626630

627631
def _test_get_index_urls_different_versions(env):
628632
got = parse_requirements(
629-
ctx = _mock_ctx(),
630633
requirements_by_platform = {
631634
"requirements_multi_version": [
632635
"cp39_linux_x86_64",
@@ -675,14 +678,14 @@ def _test_get_index_urls_different_versions(env):
675678
evaluate_markers = lambda _, requirements: evaluate_markers(
676679
requirements = requirements,
677680
platforms = {
678-
"cp39_linux_x86_64": struct(
679-
env = {"python_full_version": "3.9.0"},
680-
),
681681
"cp310_linux_x86_64": struct(
682682
env = {"python_full_version": "3.10.0"},
683683
),
684+
"cp39_linux_x86_64": struct(
685+
env = {"python_full_version": "3.9.0"},
686+
),
684687
},
685-
)
688+
),
686689
)
687690

688691
env.expect.that_collection(got).contains_exactly([

0 commit comments

Comments
 (0)