fix typo; fix broken test

Author: rickeylev

python/private/stage1_bootstrap_template.sh

@@ -132,12 +132,12 @@ if [[ "$IS_ZIPFILE" == "1" ]]; then
   mkdir -p "$(dirname $python_exe)"
   ln -s "$symlink_to" "$python_exe"
 elif [[ "$RECREATE_VENV_AT_RUNTIME" == "1" ]]; then
-  if [[ -n "$RULES_PYTHON_EXTRACT_ROOTT" ]]; then
+  if [[ -n "$RULES_PYTHON_EXTRACT_ROOT" ]]; then
     use_exec=1
     # Use our runfiles path as a unique, reusable, location for the
     # binary-specific venv being created.
-    venv="$RULES_PYTHON_EXTRACT_ROOTT/$(dirname $(dirname $PYTHON_BINARY))"
-    mkdir -p $RULES_PYTHON_EXTRACT_ROOTT
+    venv="$RULES_PYTHON_EXTRACT_ROOT/$(dirname $(dirname $PYTHON_BINARY))"
+    mkdir -p $RULES_PYTHON_EXTRACT_ROOT
   else
     # Re-exec'ing can't be used because we have to clean up the temporary
     # venv directory that is created.

tests/bootstrap_impls/run_binary_venvs_use_declare_symlink_no_test.sh

@@ -47,8 +47,8 @@ function expect_match() {
 
 expect_match "sys.executable:.*tmp.*python3" "$actual"
 
-venvs_root=$(mkdir -d)
-
+# Now test that using a custom location for the bootstrap files works
+venvs_root=$(mktemp -d)
 actual=$(RULES_PYTHON_EXTRACT_ROOT=$venvs_root $bin)
 expect_match "sys.executable:.*$venvs_root" "$actual"